Skip to content

updated rtf snapshots#227

Merged
llrs-roche merged 4 commits into
insightsengineering:mainfrom
eanokian:junco_patch_release_v0.1.5
Apr 28, 2026
Merged

updated rtf snapshots#227
llrs-roche merged 4 commits into
insightsengineering:mainfrom
eanokian:junco_patch_release_v0.1.5

Conversation

@eanokian
Copy link
Copy Markdown
Contributor

with the recent CRAN release of tidytlg v0.12.0, the rtfs snapshots have changed because there is some logic now implemented that each leading whitespace in the first column of the header is translated to left-indentation of 90 twips (approx 0.06 inches), see relevant PR: pharmaverse/tidytlg#62

with the recent CRAN release of tidytlg v0.12.0, the rtfs snapshots have changed because there is some logic now implemented that each leading whitespace in the first column of the header is translated to left-indentation of 90 twips (approx 0.06 inches), see relevant PR: pharmaverse/tidytlg#62
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 23, 2026

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@eanokian
Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@munoztd0 munoztd0 self-requested a review April 23, 2026 09:45
Comment thread tests/testthat/_snaps/lsfecg01/lsfecg01.rtf
@eanokian eanokian marked this pull request as draft April 23, 2026 13:20
@eanokian eanokian marked this pull request as ready for review April 23, 2026 14:05
@llrs-roche
Copy link
Copy Markdown
Contributor

Hi! I'm helping @shajoezhu with this issue.
@eanokian I approved the GHA but unfortunately it fails for 7 tests:

══ Failed tests ════════════════════════════════════════════════════════════════
  ── Failure ('test-lsfecg01.R:2:3'): lsfecg01 ───────────────────────────────────
  Snapshot of `write_test_rtf_for("lsfecg01.R")` has changed.
  
  ── Failure ('test-lsfecg02part1.R:2:3'): lsfecg02part1of3 ──────────────────────
  Snapshot of `write_test_rtf_for("lsfecg02.R", part_num = 1, total_parts = 3)` has changed.
  
  ── Failure ('test-lsfecg02part2.R:2:3'): lsfecg02part2of3 ──────────────────────
  Snapshot of `write_test_rtf_for("lsfecg02.R", part_num = 2, total_parts = 3)` has changed.
  
  ── Failure ('test-lsfecg02part3.R:2:3'): lsfecg02part3of3 ──────────────────────
  Snapshot of `write_test_rtf_for("lsfecg02.R", part_num = 3, total_parts = 3)` has changed.
  
  ── Failure ('test-lsfvit01.R:2:3'): lsfvit01 ───────────────────────────────────
  Snapshot of `write_test_rtf_for("lsfvit01.R")` has changed.
  
  ── Failure ('test-lsfvit02.R:2:3'): lsfvit02 ───────────────────────────────────
  Snapshot of `write_test_rtf_for("lsfvit02.R")` has changed.
  
  ── Failure ('test-lsidem02.R:2:3'): lsidem02 ───────────────────────────────────
  Snapshot of `write_test_rtf_for("lsidem02.R")` has changed.

Could those be updated too? Thanks

@llrs-roche llrs-roche self-assigned this Apr 27, 2026
@eanokian
Copy link
Copy Markdown
Contributor Author

@llrs-roche done, could you try again running the CI pipeline?

Copy link
Copy Markdown
Contributor

@llrs-roche llrs-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now @eanokian. Many thanks for the notice and the PR.

@llrs-roche llrs-roche enabled auto-merge (squash) April 28, 2026 07:54
@llrs-roche llrs-roche merged commit bcab2f9 into insightsengineering:main Apr 28, 2026
28 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants