-
-
Notifications
You must be signed in to change notification settings - Fork 11
Preparations for the release #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
20c7bdc
f0bdda8
5d05073
a4aef8d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -98,6 +98,9 @@ ard_stats_prop_test <- function(data, by, variables, conf.level = 0.95, ...) { | |
| #' @param ... passed to `prop.test(...)` | ||
| #' | ||
| #' @return ARD data frame | ||
| #' @examples | ||
| #' NULL | ||
| #' | ||
| #' @keywords internal | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment as above.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Noted, I will not remove internal help pages. I removed the help page because CRAN requests to have examples and document values too for the internal help pages. |
||
| .format_proptest_results <- function(by, variable, lst_tidy, ...) { | ||
| # build ARD ------------------------------------------------------------------ | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please avoid making updates based on opinionated ways of documenting functions. I like having help files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted, I will not remove internal help pages.
I removed the help page because CRAN requests to have examples and document values too for the internal help pages.
Internal help pages are not listed on the index but users can reach them if they want. I will simply fill in the section with NULL.