chore: various updates to improve debugging apps#123
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR comprises several changes:
with_span_list)TRACING_WITH_FILE_AND_LINE_NOto a non-empty valueinit4function is now deprecated in favour of a similarinitfunction which requires the tracing and metrics configs to be passed in. The idea is that callers will add these configs to their main config of their app, and hence all the env vars including the tracing and metrics ones will be visible via theinventoryand checkable via thecheck_inventorymethodscheck_inventory's error case to also include env vars which are set to an empty valueOptionalBoolWithDefaultwhich are designed to be used as members of config structs. These are provided with a const generic arg to be used as the default, allowing the config to not have to deal withOption<T>where the optional value is always set toSomeafter callingfrom_env.