Skip to content

chore: various updates to improve debugging apps#123

Open
Fraser999 wants to merge 4 commits intomainfrom
fraser/eng-1943/various-updates
Open

chore: various updates to improve debugging apps#123
Fraser999 wants to merge 4 commits intomainfrom
fraser/eng-1943/various-updates

Conversation

@Fraser999
Copy link
Contributor

@Fraser999 Fraser999 commented Feb 28, 2026

This PR comprises several changes:

  1. disables connection pooling in OAuth job to avoid stale connection errors, and reduces log level from error to warn for failing to refresh the OAuth token (as this is a non-critical error I believe)
  2. avoids recording the current span twice (it's recorded as the last entry in "spans" since we enable with_span_list)
  3. supports including file and line number in log lines by setting the env var TRACING_WITH_FILE_AND_LINE_NO to a non-empty value
  4. a somewhat larger change to env var handling:
    • the existing init4 function is now deprecated in favour of a similar init function which requires the tracing and metrics configs to be passed in. The idea is that callers will add these configs to their main config of their app, and hence all the env vars including the tracing and metrics ones will be visible via the inventory and checkable via the check_inventory methods
    • added the tracing config, which internally holds an optional OTEL config
    • updated check_inventory's error case to also include env vars which are set to an empty value
    • added a set of types like OptionalBoolWithDefault which are designed to be used as members of config structs. These are provided with a const generic arg to be used as the default, allowing the config to not have to deal with Option<T> where the optional value is always set to Some after calling from_env.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Fraser999 Fraser999 marked this pull request as ready for review February 28, 2026 02:17
@Fraser999 Fraser999 changed the title disable conn pooling in oauth job and reduce log level chore: various updates to improve debugging apps Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant