Closed
Conversation
dadadavorin
reviewed
Jan 28, 2025
dadadavorin
previously approved these changes
Jan 28, 2025
piqusy
requested changes
Jan 29, 2025
Contributor
piqusy
left a comment
piqusy
left a comment
There was a problem hiding this comment.
Looking good, just two minor suggestions
| Add additional items to the top bar menu under the Add-on parent. | ||
|
|
||
| ```php | ||
| add_filter('es_forms_admin_top_bar_menu_items', 'getTopBarMenuItems', 10, 2); |
Contributor
There was a problem hiding this comment.
Suggested change
| add_filter('es_forms_admin_top_bar_menu_items', 'getTopBarMenuItems', 10, 2); | |
| \add_filter('es_forms_admin_top_bar_menu_items', 'getTopBarMenuItems', 10, 2); |
| You don't need to provide order for all countries, only the ones you want to change the order and the rest will be displayed in the default order. | ||
|
|
||
| ```php | ||
| add_filter('es_forms_block_country_custom_order', 'getBlockCountryCustomOrder'); |
Contributor
There was a problem hiding this comment.
Suggested change
| add_filter('es_forms_block_country_custom_order', 'getBlockCountryCustomOrder'); | |
| \add_filter('es_forms_block_country_custom_order', 'getBlockCountryCustomOrder'); |
Contributor
|
Any news on merging this? Or updating? |
Member
Author
|
it will be done in the next 2 weeks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.