Update ProMotion dependency to current version #41
Open
wndxlori wants to merge 4 commits intoinfinitered:masterfrom
Open
Update ProMotion dependency to current version #41wndxlori wants to merge 4 commits intoinfinitered:masterfrom
wndxlori wants to merge 4 commits intoinfinitered:masterfrom
Conversation
|
Hey @wndxlori, looks good to me. I noticed there's still a failing test. Not sure if it was failing before or not. What do you think about it? |
Author
|
That's a "works for me" error, @andrewhavens. Not sure why it doesn't work on the Travis Build. I suspect something about "location" not working on the build VM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would appreciate getting this merged quickly, if possible. It's a minor update to keep up with the Promotion version, with a couple of build fixes thrown in.