Allow the user to customize the stack depth to skip.#128
Open
xgfone wants to merge 8 commits intoinconshreveable:masterfrom
xgfone:feature-curstomize-stack
Open
Allow the user to customize the stack depth to skip.#128xgfone wants to merge 8 commits intoinconshreveable:masterfrom xgfone:feature-curstomize-stack
xgfone wants to merge 8 commits intoinconshreveable:masterfrom
xgfone:feature-curstomize-stack
Conversation
Add the stack depth
…e same depth as the parent
Contributor
|
Two things missing on this PR
My additional changes for Revel |
Add the stack depth
Author
Closed
…e same depth as the parent
…to feature-curstomize-stack
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the hard-coded stack depth to skip. So the user can customize it by the actual demand.
For example, I want to wrap
log15.Loggerin my struct.Before this, I have to discard the stack information of
log15.Loggerand rewrite it myself.