Make the logging time format configurable.#100
Open
kormat wants to merge 1 commit intoinconshreveable:masterfrom
Open
Make the logging time format configurable.#100kormat wants to merge 1 commit intoinconshreveable:masterfrom
kormat wants to merge 1 commit intoinconshreveable:masterfrom
Conversation
This is a very basic approach, but it is pretty non-invasive, doesn't have a runtime overhead, and provides a fix until inconshreveable#35 is resolved in a more comprehensive way.
Author
|
We've been using this for the last 3 years and it's worked fine. Rebased on master, just in case there's a chance of getting it merged :) |
|
@kevinburke - Can this PR be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very basic approach, but it is pretty non-invasive, doesn't
have a runtime overhead, and provides a fix until #35 is resolved in a
more comprehensive way.
This change is