Upgrade Vite to version 8 and remove vite-tsconfig-paths#54
Conversation
Vite 8 supports tsconfig path resolution natively via the `resolve.tsconfigPaths: true` option (Vite 7 already emitted a deprecation warning recommending this), so the `vite-tsconfig-paths` plugin is no longer needed. Drops the devDependency and replaces the `tsconfigPaths()` plugin call in `vite.config.ts` and `vitest.config.ts`. The three changes are coupled and must land together: removing the plugin alone would break the imports, and switching to the native option requires Vite 8.
There was a problem hiding this comment.
Pull request overview
Upgrades the Ignis.Web build/test toolchain to Vite 8 and removes vite-tsconfig-paths, updating Vite/Vitest configuration to rely on Vite’s native tsconfig path handling.
Changes:
- Bump
vitefrom^7.3.2to^8.0.10and removevite-tsconfig-pathsfrom devDependencies. - Update
vite.config.tsandvitest.config.tsto replace the plugin withresolve.tsconfigPaths: true. - Refresh
package-lock.jsonfor the new dependency graph (notably introducingrolldownvia Vite 8).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Ignis.Web/vitest.config.ts | Removes vite-tsconfig-paths usage and switches to resolve.tsconfigPaths. |
| src/Ignis.Web/vite.config.ts | Removes vite-tsconfig-paths plugin and switches to resolve.tsconfigPaths. |
| src/Ignis.Web/package.json | Upgrades Vite to v8 and removes vite-tsconfig-paths dependency. |
| src/Ignis.Web/package-lock.json | Updates lockfile for Vite 8 and removes vite-tsconfig-paths transitive deps. |
Files not reviewed (1)
- src/Ignis.Web/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "typescript-eslint": "^8.59.1", | ||
| "vite": "^7.3.2", | ||
| "vite-tsconfig-paths": "^5.1.4", | ||
| "vite": "^8.0.10", |
There was a problem hiding this comment.
Thanks for this, will await an update of @react-router/dev before merging
| "node_modules/vite-node/node_modules/vite": { | ||
| "version": "7.3.2", | ||
| "resolved": "https://registry.npmjs.org/vite/-/vite-7.3.2.tgz", | ||
| "integrity": "sha512-Bby3NOsna2jsjfLVOHKes8sGwgl4TT0E6vvpYgnAYDIF/tie7MRaFthmKuHx1NSXjiTueXH3do80FMQgvEktRg==", | ||
| "dev": true, |
There was a problem hiding this comment.
Will await upgrade to avoid this conflict
|
As @react-router/dev is pulling in vite-node@3.2.4, with vite dependency ^5 || ^6 || ^7 we are getting both vite v7 and v8. As we have no needs for vite v8, we will just put this on hold until all dependencies are supporting vite 8 |
Bump Vite to version 8, which natively supports tsconfig path resolution. Remove the vite-tsconfig-paths plugin and update the configuration accordingly to ensure compatibility. These changes are interdependent and must be applied together.