Skip to content

Spp 003 nl#153

Draft
karenwuyts wants to merge 99 commits intomainfrom
spp-003-nl
Draft

Spp 003 nl#153
karenwuyts wants to merge 99 commits intomainfrom
spp-003-nl

Conversation

@karenwuyts
Copy link

@karenwuyts karenwuyts commented Mar 25, 2026

Description

This project-specific protocol describes the guidelines and steps for the manual installation of ground water wells in terrestrial and aquatic habitat types for monitoring of the ground water chemistry (nitrogen) for the Monitoring Programme for the Natural Environment (MNE; Meetnetten Natuurlijk Milieu, MNM). It makes use of protocol sfp_104_nl.

Related Issue

Task list

Steps by contributor:

  • Add description to this pull request (under "## Description")
  • Open the dropdown (triangle) near 'create pull request' and choose 'Create draft pull request'
  • Check for potential problems by running protocolhelper::check_frontmatter() and address them
  • Check for potential problems by running protocolhelper::check_structure() and address them
  • Add further commits if needed and push them to GitHub
  • Update the protocol-specific NEWS.Rmd
  • Mark the pull request as 'ready for review'

Review steps for the author(s):

  • Add reviewers, at least one subject-matter specialist and one administrator
  • Wait for review comments and address them
  • Iterate until reviewer approvals (merging the pull request will be done by an administrator)
  • Verify that the checks done by continuous integration succeeded. These will check if protocolhelper::check_frontmatter() and protocolhelper::check_structure() succeeded without errors.

To be done by an administrator after review: see guidelines for admins.

@ThierryO
Copy link
Member

@hansvancalster

  • the Docker issue is "package 'slickR' is not available"
  • you should remove the libs folder from the history and add it to the .gitignore

@hansvancalster
Copy link
Collaborator

the Docker issue is "package 'slickR' is not available"

That is strange. The slickR package is no longer used. I guess that docker is using an old image?

  • you should remove the libs folder from the history and add it to the .gitignore

@karenwuyts The "remove the libs folder from the history" is something we will need to fix together. The update of .gitignore is something I must do via a separate pull request.

@ThierryO
Copy link
Member

ThierryO commented Mar 25, 2026

the Docker issue is "package 'slickR' is not available"

That is strange. The slickR package is no longer used. I guess that docker is using an old image?

"slickR",

This is due to the out of date branch. I would suggest to rebase this branch to the current main branch. This is something that @hansvancalster should fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants