Refactor visit node to reduce rightward drift#1405
Open
bungcip wants to merge 2 commits intoimmunant:masterfrom
Open
Refactor visit node to reduce rightward drift#1405bungcip wants to merge 2 commits intoimmunant:masterfrom
bungcip wants to merge 2 commits intoimmunant:masterfrom
Conversation
bungcip
commented
Oct 9, 2025
| @@ -583,8 +583,7 @@ impl ConversionContext { | |||
| }) | |||
| } | |||
|
|
|||
| /// Visit one node. | |||
| fn visit_node( | |||
| fn convert_node_as_type( | |||
Contributor
Author
There was a problem hiding this comment.
bikeshedding welcome for the function name
Contributor
There was a problem hiding this comment.
fn visit_type_node perhaps? Otherwise this LGTM.
Contributor
Author
There was a problem hiding this comment.
visit_node_type already exist, so naming it visit_type_node will make it more confusing😅
Contributor
There was a problem hiding this comment.
Hmm, node_as_type is okay then, but I think visit should be kept.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
visit_nodeinconversion.rsis very big, this PR try to split the function and use early return to reduce rightward drift