fix: warning instead of error for invalid icc when decoding jpeg#138
Merged
fix: warning instead of error for invalid icc when decoding jpeg#138
Conversation
mertalev
force-pushed
the
fix/handle-invalid-icc
branch
from
a83499d to
c13a251
Compare
martabal
approved these changes
Oct 31, 2024
Contributor
martabal
left a comment
martabal
left a comment
There was a problem hiding this comment.
If we start to have multiple patches, can we store them in a patch folder?
mertalev
force-pushed
the
fix/handle-invalid-icc
branch
from
104c147 to
9b851f5
Compare
martabal
reviewed
Oct 31, 2024
| *.deb \ | ||
| /var/lib/apt/lists | ||
| /var/lib/apt/lists \ | ||
| /usr/lib/$(arch)-linux-gnu/libjpeg.so* \ |
Contributor
There was a problem hiding this comment.
Why do you want to remove libjpeg?
Sharp does not use by default the decoder from /usr/local/lib?
root@03fa65ee8b06:/# ldd /usr/local/bin/vips | grep jpeg
libjpeg.so.8 => /usr/local/lib/libjpeg.so.8 (0x000014f26b39f000)
Member
Author
There was a problem hiding this comment.
It makes the image smaller and avoids any ambiguity.
jrasm91
approved these changes
Oct 31, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If the ICC profile is corrupt, it can be ignored without preventing the image from being decoded. This PR adds a patch to make this change until this is handled upstream with this PR.
Also changes build cleanup to delete libjpeg-turbo files manually instead of using dpkg, as the latter results in apt complaining.
Testing
Tested with this sample image and confirmed that it was processed successfully with this change, but failed without it.