Fix PHP version constraint to match php-jwt v7 requirements#66
Merged
maztch merged 1 commit intoilovepdf:developfrom Apr 20, 2026
Merged
Conversation
Follow-up to ilovepdf#64 - firebase/php-jwt was upgraded to ^7.0 which requires PHP >=8.0, but the PHP constraint was not updated.
|
Seems my work colleague forgot to notify you, so I might as well do it for him: @maztch |
|
In JWT version 6 there is a weak encryption, UP for this PR |
|
i'd also be happy for there to be a release soon, there is no point if this stays in develop forever |
|
UP |
1 similar comment
|
UP |
|
@maztch, when will the new version with this fix be released? |
maztch
added a commit
that referenced
this pull request
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #64 —
firebase/php-jwtwas upgraded to^7.0, but the PHP version constraint was not updated.Problem
firebase/php-jwtv7 requires PHP >=8.0, butcomposer.jsonstill declares"php": ">=7.3". This meanscomposer installon PHP 7.x will fail with an unresolvable dependency, which is confusing for users.See: https://github.com/firebase/php-jwt/blob/main/composer.json
Changes
composer.json:"php": ">=7.3"→"php": ">=8.0"readme.md: PHP requirement updated from 7.4 to 8.0Why this is safe
JWT::encode()API is identical in v7