Skip to content

fix(watch-button): eliminate N+1 API calls on profile watchlist #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alm0stSurely wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(watch-button): eliminate N+1 API calls on profile watchlist #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion frontend/app/(auth)/profile/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,12 @@ function Watchlist() {
</div>
</div>
<div className="shrink-0">
<WatchButton owner={repo.repo_owner} name={repo.repo_name} />
<WatchButton
owner={repo.repo_owner}
name={repo.repo_name}
initialIsWatched={true}
onUnwatch={() => setRepos(prev => prev.filter(r => r.id !== repo.id))}
/>
</div>
</div>
</div>
Expand Down
16 changes: 12 additions & 4 deletions frontend/components/watch-button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,21 +9,28 @@ import { toast } from "sonner";
interface WatchButtonProps {
owner: string;
name: string;
initialIsWatched?: boolean;
onUnwatch?: () => void;
}

export function WatchButton({ owner, name }: WatchButtonProps) {
export function WatchButton({ owner, name, initialIsWatched, onUnwatch }: WatchButtonProps) {
const { token } = useAuth();
const [isWatched, setIsWatched] = useState(false);
const [loading, setLoading] = useState(true);
const [isWatched, setIsWatched] = useState(initialIsWatched ?? false);
const [loading, setLoading] = useState(initialIsWatched === undefined);

useEffect(() => {
// Skip the API call if the parent gave us the initial state
if (initialIsWatched !== undefined) {
setLoading(false);
return;
}
if (token) {
checkIsWatched(token, owner, name)
.then(setIsWatched)
.catch(() => setIsWatched(false))
.finally(() => setLoading(false));
}
}, [token, owner, name]);
}, [token, owner, name, initialIsWatched]);

const toggleWatch = async () => {
if (!token) return;
Expand All @@ -34,6 +41,7 @@ export function WatchButton({ owner, name }: WatchButtonProps) {
await removeFromWatchlist(token, owner, name);
setIsWatched(false);
toast.success("Removed from watchlist");
onUnwatch?.();
} else {
await addToWatchlist(token, owner, name);
setIsWatched(true);
Expand Down