Skip to content

Fix postwalk destroying any objects (CIDER compatibility) #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DeLaGuardo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix postwalk destroying any objects (CIDER compatibility) #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/any/core.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@
IPersistentCollection
(equiv [~this ~other]
~@body)
(empty [~this]
~this)
(seq [~this]
nil)
~@(when repr
[`(toString [~this] ~repr)]))]
(defmethod print-method (type result#)
Expand Down
25 changes: 25 additions & 0 deletions test/any/core_test.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
(:refer-clojure :exclude [random-uuid])
(:require
[clojure.test :refer [deftest is testing]]
[clojure.walk :as walk]
[any.core :as any]))

;; for Clojure < 11
Expand Down Expand Up @@ -136,6 +137,30 @@
(is (= any/chars (char-array 32)))
(is (= any/objects (object-array 32))))

(deftest test-postwalk-preserves-any-objects
(testing "postwalk identity preserves scalar any objects"
(is (identical? any/uuid (walk/postwalk identity any/uuid)))
(is (identical? any/string (walk/postwalk identity any/string)))
(is (identical? any/int (walk/postwalk identity any/int))))

(testing "postwalk preserves any objects nested in collections"
(is (= [any/uuid any/string]
(walk/postwalk identity [any/uuid any/string])))
(is (= {:id any/uuid :name any/string}
(walk/postwalk identity {:id any/uuid :name any/string}))))

(testing "cider-nrepl deep-sorted-maps simulation"
(let [deep-sorted-maps
(fn [m]
(walk/postwalk
(fn [x]
(if (and (map? x) (not (record? x)))
(into (sorted-map) x)
x))
m))]
(is (identical? any/uuid (deep-sorted-maps any/uuid)))
(is (= {:id any/uuid :name "test"}
(deep-sorted-maps {:id any/uuid :name "test"}))))))

(comment ;; demo for readme

Expand Down