Fix a lot of strings being hardcoded and untranslatable by VladisCrafter · Pull Request #35 · iglee42/CreateQualityOfLife

VladisCrafter · 2025-08-28T15:06:07Z

Summary:

What was "dehardcoded":

All Statue-related strings (main tab labels, scale scroll, statue/player/animation names);
Armor & Tools strings (function displays in the inventory, function activation messages);
(Partially) Inventory/Item/Tooltip config screens (the UI itself, not the tooltips);
Display board edit screen strings (Glowing button AND color names);
The Stock Manager warning chat message (also split it in two for easier editing).

Important:

Some of strings have identical values in en_us.json, but are technically different for a reason. For example, "createqol.function.tools.vein_mine" is used in the inventory, and
"createqol.tool.vein_mine_toggle" - is shown in the client's screen when it's enabled.
Thus, messages can be customized separately.

Corrections:

If you dislike the localization key values or their placements in the lang files, you can request changes or change them yourself BUT mind the following:

If former: mass replace, not by hand (as some keys are used in a lot of places);
If latter: please move them in ru_ru.json as well, so future translation won't require doing that again.

Phew.

VladisCrafter · 2025-08-28T15:10:23Z

@mpustovoi, fancy reviewing this abomination? :]
Only the ru_ru ofc 😅

mpustovoi

ru_ru.json is fine tho.

iglee42 · 2025-08-28T15:20:27Z

src/main/java/fr/iglee42/createqualityoflife/items/armors/ShadowRadianceArmorItem.java

                    (e,oE)->true
            ));
+        }else if (getType() == ArmorItem.Type.LEGGINGS){
+            list.add(Configuration.ofBool("Void Walking",


Could be Translated with CreateQOLLang.translateDirect("xxxx").getString()

Could be Translated with CreateQOLLang.translateDirect("xxxx").getString()

I decided to not touch strings of the config itself, since Create mod's config is surprisingly hardcoded as well. Maybe that will change in the future but I think it's better to leave it like that for the sake of consistency.

iglee42 · 2025-08-28T15:20:31Z

src/main/java/fr/iglee42/createqualityoflife/items/armors/ShadowRadianceArmorItem.java

+            list.add(Configuration.ofBool("Void Walking",
+                    stack.getOrDefault(QOLDataComponents.VOID_WALK,true),
+                    QOLDataComponents.VOID_WALK,
+                    List.of("Enable walking on void"),


iglee42 · 2025-08-28T15:21:11Z

src/main/java/fr/iglee42/createqualityoflife/items/armors/ShadowRadianceArmorItem.java

+                    .withStyle(ChatFormatting.GOLD)
+                    .append(QOLConfigurableItem.chooseState(CreateQOLConfigs.server().equipments.armors.voidWalking.get(),
+                            true, stack.getOrDefault(QOLDataComponents.VOID_WALK, true), false, true)));
+            components.add(Component.translatable("createqol.function.armor.step_height")


Why did you use Component.translatable() instead of CreateQOLLang.translateDirect("xxxx").getString()?

Why did you use Component.translatable() instead of CreateQOLLang.translateDirect("xxxx").getString()?

I tried replicating your style of translating by using CreateQOLLang.translateDirect("xxxx") mainly in client messages and some other stuff. I also remember seeing that:

/**

legacy-ish. Use CreateQOLLang.translate and other builder methods where possible

*/

...so I'm not sure if it was good to use at all 🤷‍♂️

iglee42 · 2025-08-28T15:26:28Z

src/main/java/fr/iglee42/createqualityoflife/items/tools/shadowradiance/ShadowRadianceHoe.java

        if (player.isCrouching()){
            if (player.getItemInHand(hand).getOrDefault(QOLDataComponents.HARVESTING,false)){
-                player.displayClientMessage(Component.literal("Ploughing can't be enabled if harvesting is enabled").withStyle(ChatFormatting.RED),true);
+                player.displayClientMessage(Component.translatable("createqol.tool.ploughing_unavailable").withStyle(ChatFormatting.RED),true);


Could be generic with something like CreateQOLLang.translateDirect("function.state.disabled_by",CreateQOL.translateDirect("function.tool.smelting").getString(),CreateQOL.translateDirect("function.tool.digging").getString())

Could be generic with something like CreateQOLLang.translateDirect("function.state.disabled_by",CreateQOL.translateDirect("function.tool.smelting").getString(),CreateQOL.translateDirect("function.tool.digging").getString())

Yeah, I can try that.

iglee42 · 2025-08-28T15:28:33Z

src/main/resources/assets/createqol/lang/en_us.json

+  "createqol.tool.vein_mine_disabled": "Vein Mine is disabled by the config",
+  "createqol.tool.vein_mine_unavailable": "Vein Mine can't be enabled if digging is enabled",
+
+  "createqol.tool.casingifier_toggle": "Casingifier : ",


Why did you put the : in the translation, it means we won't be able to use it elsewhere than the tooltip.

Why did you put the : in the translation, it means we won't be able to use it elsewhere than the tooltip.

Well, actually you did. I copied the string one-to-one :]
But yeah, I can remove the : from this type of strings.

And, if by "elsewhere" you have a specific thought, I'd like to know.

iglee42 · 2025-08-28T15:28:58Z

src/main/resources/assets/createqol/lang/en_us.json

+  "createqol.chestplate.dash_disabled": "Dashing is disabled on this server !",
+  "createqol.chestplate.dash_reloading": "Dashing is reloading, please wait!",
+
+  "createqol.tool.casingifier_disabled": "Casingifier is disabled by the config",


Theses messages can be more generic with %s

Theses messages can be more generic with %s

Got It!

iglee42 · 2025-08-28T15:38:43Z

Also I think you can merge duplicate keys because if they have to be edited I will forgot one for sure and in english it doesn't cause issues if they are the same.
I don't know in russian

…y are initially called in the config

VladisCrafter · 2025-08-28T16:35:29Z

Also I think you can merge duplicate keys because if they have to be edited I will forgot one for sure and in english it doesn't cause issues if they are the same. I don't know in russian

That's the issue. I'd suggest keeping them as different strings: short type to be displayed in the inventory and long type for client messages.

…r/CreateQualityOfLife into string_dehardcoding

iglee42

Seems all good

VladisCrafter and others added 9 commits August 28, 2025 16:21

Fix ru_ru.json

13687c9

Fix ru_ru.json again (for the last time)

d0d0b38

Dehardcode Statue strings

416ecf4

Dehardcode armor & tools strings

1a51b84

Dehardcode config screens strings

c88b926

Dehardcode display board edit screen strings

8878bc5

Dehardcode the warning message string, split in two for easier editing

ba1031e

Fixes before release

ef624dc

Dehardcode armor strings added in "Fixes before release" commit

98c4d78

iglee42 self-assigned this Aug 28, 2025

Merge branch '1.21.1' into string_dehardcoding

6c0b7cc

mpustovoi approved these changes Aug 28, 2025

View reviewed changes

iglee42 requested changes Aug 28, 2025

View reviewed changes

Rename armor/tools "functions" to "abilities" for parity with how the…

678ed0b

…y are initially called in the config

VladisCrafter added 4 commits August 29, 2025 15:54

Generic-ify armor/tools abilities

7374aa9

Merge branch 'string_dehardcoding' of https://github.com/VladisCrafte…

59df652

…r/CreateQualityOfLife into string_dehardcoding

Fix ru_ru.json

3507aab

Fix ru_ru.json again lol

6790d2c

VladisCrafter marked this pull request as ready for review August 29, 2025 13:06

iglee42 approved these changes Aug 29, 2025

View reviewed changes

iglee42 merged commit 5d551c8 into iglee42:1.21.1 Aug 29, 2025
0 of 3 checks passed

Conversation

VladisCrafter commented Aug 28, 2025

Summary:

Important:

Corrections:

Uh oh!

VladisCrafter commented Aug 28, 2025

Uh oh!

mpustovoi left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iglee42 commented Aug 28, 2025

Uh oh!

VladisCrafter commented Aug 28, 2025

Uh oh!

iglee42 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants