Skip to content

blk_1m: assert T>0, not theta>0 #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pdziekan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

blk_1m: assert T>0, not theta>0 #361

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/libcloudph++/blk_1m/adj_cellwise.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@ namespace libcloudphxx
&rc = std::get<3>(tup);

// double-checking....
assert(th >= 273.15); // TODO: that's theta, not T!
assert(rc >= 0);
assert(rv >= 0);

Expand All @@ -118,6 +117,7 @@ namespace libcloudphxx
auto exner_p = theta_std::exner(p);

quantity<si::temperature, real_t> T = th_tmp * exner_p;
assert(T >= 273.15 * si::kelvins);

// constant l_v used in theta update
auto L0 = const_cp::l_v(T);
Expand Down