feat: add wait command with non-zero exit on failure#28
Open
183amir wants to merge 4 commits intofeat/json-outputfrom
Open
feat: add wait command with non-zero exit on failure#28183amir wants to merge 4 commits intofeat/json-outputfrom
183amir wants to merge 4 commits intofeat/json-outputfrom
Conversation
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace ctx.exit(1) with raise SystemExit(1) to ensure click.echo output is flushed before the process exits. ctx.exit(1) can suppress output in some Python/Click versions (e.g. Python 3.9). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Ensures the DB session is properly committed before raising SystemExit to avoid leaving the database in a bad state. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
183amir
force-pushed
the
feat/wait-command
branch
from
bfb8ffc to
d0c3beb
Compare
|
|
||
| # Show progress | ||
| pending = sum(1 for j in jobs if j.state not in terminal_states) | ||
| click.echo(f"Waiting for {pending} job(s)... (checking every {interval}s)") |
Member
There was a problem hiding this comment.
Would it make sense to have a more detailed view with counts of jobs in "PENDING" state and jobs in "RUNNING" state?
We could know if we are waiting for jobs to be started or for running jobs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gridtk waitcommand that polls jobs until all reach a terminal state--intervaloption and all standard job filterswaitcommand in READMEExamples
🤖 Generated with Claude Code
📚 Documentation preview 📚: https://gridtk--28.org.readthedocs.build/en/28/