Skip to content

fix: show feedback when commands match no jobs#27

Merged
183amir merged 6 commits intomainfrom
fix/empty-result-feedback
Mar 16, 2026
Merged

fix: show feedback when commands match no jobs#27
183amir merged 6 commits intomainfrom
fix/empty-result-feedback

Conversation

@183amir
Copy link
Collaborator

@183amir 183amir commented Mar 16, 2026

Summary

  • Show feedback when commands match no jobs instead of silent no-op
  • Only resubmit hints about its default state filter since users may not realize it's active

Examples

$ gridtk list
No jobs were found.

$ gridtk resubmit
No jobs were resubmitted. Note: the default state filter is active. Use --state all to include all jobs.

$ gridtk stop
No jobs were stopped.

$ gridtk delete
No jobs were deleted.

🤖 Generated with Claude Code


📚 Documentation preview 📚: https://gridtk--27.org.readthedocs.build/en/27/

Amir Mohammadi and others added 2 commits March 16, 2026 17:09
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions
Copy link

github-actions bot commented Mar 16, 2026

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/gridtk
  cli.py 549, 574, 606
Project Total  

This report was generated by python-coverage-comment-action

Amir Mohammadi and others added 4 commits March 16, 2026 17:25
Add no_jobs_message() helper that includes active filters in the
message so users understand why no jobs matched.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
When default state filters are active (e.g. resubmit), suggest
--state all. When explicit filters are provided, show them.
When no filters at all, just state the fact.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@183amir 183amir requested a review from Yannick-Dayer March 16, 2026 16:55
@183amir 183amir mentioned this pull request Mar 16, 2026
@183amir 183amir merged commit ffd9e13 into main Mar 16, 2026
10 checks passed
@183amir 183amir deleted the fix/empty-result-feedback branch March 16, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants