Skip to content

640/dietary preferences and allergens#651

Merged
LexTruong merged 13 commits intodevfrom
640/dietary-preferences-and-allergens
Apr 8, 2026
Merged

640/dietary preferences and allergens#651
LexTruong merged 13 commits intodevfrom
640/dietary-preferences-and-allergens

Conversation

@Pranav-Batra
Copy link
Copy Markdown
Contributor

Summary

Users can see their dietary prefs/allergens in menu, see which meals conflict with their prefs, and view only meals that agree with their prefs

Changes

Removed hardcoded prefs/allergens on user menu with their actual prefs/allergens
Added red warning badge on meals that do not meet user preferences(either contain an allergen or dont meet dietary prefs)
Added "show preferences only" button to toggle the restaurant pages to only show meals that match user dietary preferences

Closes #640

@Pranav-Batra Pranav-Batra temporarily deployed to staging-651 February 26, 2026 00:50 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-651 February 26, 2026 00:50 Inactive
@EightBitByte EightBitByte self-requested a review February 26, 2026 01:32
Copy link
Copy Markdown
Collaborator

@LexTruong LexTruong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! UI/UX is still finalizing the look of the conflict indicators, so we're not too worried about the styling. But what you have so far looks pretty nice.

  • Please add an indicator on the meal dialog/drawers for incompatibility.
  • Remove unnecessary comments.

@Pranav-Batra Pranav-Batra temporarily deployed to staging-651 February 28, 2026 21:43 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-651 February 28, 2026 21:43 Inactive
Copy link
Copy Markdown
Collaborator

@LexTruong LexTruong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Pranav, great work! Just a few touchups are needed now that the Figma has been finalized.

  • Match the styling for the badges on meal dialog/drawers. Note that they show what specific preference/allergen is problematic in that dish. Use MUI icons for the exclamation point icon.
  • I like the slightly greyed-out look on incompatible meal cards! Please change the "Conflict" badge on them to an icon though.
  • Make sure that warning icon also shows on meal cards for mobile screens.

@Pranav-Batra Pranav-Batra temporarily deployed to staging-651 March 30, 2026 18:14 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-651 March 30, 2026 18:15 Inactive
@LexTruong LexTruong requested review from LexTruong April 2, 2026 02:39
Copy link
Copy Markdown
Collaborator

@LexTruong LexTruong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Pranav, a few more changes are needed on this one.
Image

  1. The warning icon isn't quite right on the food cards. Also, the icon should be placed immediately to the right of the food name instead of in the top right of the card.
Image
  1. The warning icon isn't showing correctly on the food dialog (looks like an exclamation point instead of an icon).
  2. Also, please verify you're using the right shade of red for the warning icons on both the food card and dialogs. According to the Figma, it should be tailwind red 600.

@LexTruong LexTruong temporarily deployed to staging-651 April 5, 2026 02:07 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-651 April 5, 2026 02:08 Inactive
@Pranav-Batra Pranav-Batra temporarily deployed to staging-651 April 6, 2026 21:53 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-651 April 6, 2026 21:53 Inactive
Copy link
Copy Markdown
Collaborator

@LexTruong LexTruong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@LexTruong LexTruong merged commit 96fecb6 into dev Apr 8, 2026
1 of 2 checks passed
@LexTruong LexTruong deleted the 640/dietary-preferences-and-allergens branch April 8, 2026 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants