642/toolbar-touchup#645
Conversation
There was a problem hiding this comment.
Great work! Just a couple of minor fixes needed to further align with the Figma:
- When users are not logged in, there should only be a sign in button, not a menu icon as well.
- The menu button is not visible (white on white) on the about page when in light mode.
…late into 642/toolbar-touchup
LexTruong
left a comment
There was a problem hiding this comment.
Hey Samika! I helped merge your changes with dev to resolve the conflicts. This merge brought a new MobileToolbar in toolbar.tsx. Please make the top bar of the mobile toolbar transparent, similar to how you did for the desktop toolbar. Also, please add the thin grey line at the bottom of the the desktop toolbar on non-transparent pages.
Got it, just addressed those changes! |
LexTruong
left a comment
There was a problem hiding this comment.
Hey Samika, those changes you made look great! 2 other things I noticed though (sorry if I missed them the first time):
- Missing a link to the Meal tracker page in the toolbar
- Let's disable the Food Courts button for now since it's not implemented
TheAbubakrAbu
left a comment
There was a problem hiding this comment.
Hi Samika! Just following up on the previous comments from Lex:
- The Meal Tracker link still seems to be missing from the toolbar
- The Food Courts button is still enabled even though it’s not implemented yet
Just wanted to check if this is still being worked on. Let us know if you need anything!
Hi Abu, I'll get to these changes today! |
TheAbubakrAbu
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for the fixes!
…route
Summary
Changes