Skip to content

Fix list-key-versions command #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icedevml merged 1 commit into from
Jul 27, 2025
Merged

Fix list-key-versions command #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pykmstool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ def list_project_locations(client: kms.KeyManagementServiceClient, project_id: s
while True:
res = client.list_locations(ListLocationsRequest(
name=f'projects/{project_id}',
page_size=3,
page_token=next_page_token
))

Expand All @@ -44,7 +43,7 @@ def list_project_locations(client: kms.KeyManagementServiceClient, project_id: s
@click.option(
"--location-id",
help="Location ID to search for KMS keys within.",
required=True)
required=False)
@click.option(
"--project-id",
help="Project ID to search for KMS keys within. Will check all projects otherwise.",
Expand Down Expand Up @@ -88,6 +87,7 @@ def list_key_versions(location_id, project_id=None, service_account_file=None, q

for project_id in check_project_ids:
for location_id in check_location_ids:
click.echo(f'# Checking projects/{project_id}/locations/{location_id}')
location_path = kms_client.common_location_path(project_id, location_id)
try:
for key_ring in kms_client.list_key_rings(parent=location_path):
Expand Down