Open
Conversation
updated gitignore to ignore node_modules
Contributor
|
Hi @Frippo40, can you remove the node-modules folder from your pull request? (by adding it to your .gitignore file) |
Author
|
Hi @sulliwane can you take a look at the latest commit?dbad13c I had to run |
Amxx
suggested changes
Nov 5, 2019
Contributor
Amxx
left a comment
Amxx
left a comment
There was a problem hiding this comment.
Only 5/96 files are relevant
Unless code / duplicate from other repo should be avoided. Also don't touche files outside you your folder (changes in permissions/etc...)
| } | ||
| let deliveryStatus = results.TrackResponse.Shipment.Package.Activity[0].Status.Description; | ||
|
|
||
| var iexeccallback = ethers.utils.defaultAbiCoder.encode(['string'], [deliveryStatus]); |
Contributor
There was a problem hiding this comment.
How many possible delivery status are there? Wouldn't it make more sens to create an enum describing them, and return an uint256? This would reduce the gas costs and improve usability of the oracle
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new attempt - now deployed at https://explorer.iex.ec/kovan/app/0x8Ee07bCf22573a5D934e907E71E5127a55DAe6A0
Now the result is "standard_init_linux.go:211: exec user process caused "no such file or directory"
I'm using windows so there may be something going wrong there maybe?
I think node_modules should be ignored now but I'm also learning git in the process as well...