Fix scrollToSection() if not all cells have been rendered#63
Open
haraldreingruber wants to merge 1 commit intoi6mi6:masterfrom
Open
Fix scrollToSection() if not all cells have been rendered#63haraldreingruber wants to merge 1 commit intoi6mi6:masterfrom
haraldreingruber wants to merge 1 commit intoi6mi6:masterfrom
Conversation
It looks like the ListView component does not render all cells initially. Because of this, the ScrollToSection buttons don't work until all cells have been displayed once (e.g. scroll to bottom). Looking forward to feedback and improvement suggestions.
This was referenced Jun 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like the ListView component does not render all cells initially.
Because of this, the ScrollToSection buttons don't work until all cells have been displayed once (e.g. scroll to bottom).
Looking forward to feedback and improvement suggestions.
Note: This is merely a quick&dirty workaround. It might cause some performance penalties, as all list items will be rendered from the start.