Will allow side alphabet list to work properly on android when the co…#36
Open
mag1492 wants to merge 2 commits intoi6mi6:masterfrom
Open
Will allow side alphabet list to work properly on android when the co…#36mag1492 wants to merge 2 commits intoi6mi6:masterfrom
mag1492 wants to merge 2 commits intoi6mi6:masterfrom
Conversation
…mponent is not used as primary and only view. Will work only with empty sections allowed. FirstElement in alphabetSideListIndex has the proper offset. Less commentary.
|
I have same issue related to this commit. Please merge this commit. It will help me to reduce my issue |
ianhowe76
reviewed
Mar 6, 2018
| NativeModules | ||
| } from 'react-native'; | ||
|
|
||
| const UIManager = NativeModules; |
Collaborator
There was a problem hiding this comment.
delete - UIManager not used in this file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will work when component is not used as primary and only view.
Will work only with empty sections allowed. (Otherwise need to change section offset calculation)
FirstElement in alphabetSideListIndex has the proper offset. Works when alphabet section are not always populated with items.
Ex:
A: []
B: [{...}]
etc.