[Aikido] Fix 8 security issues in lodash, @actions/core, @actions/github and 2 more#9
Open
aikido-autofix[bot] wants to merge 1 commit intomainfrom
Open
Conversation
There was a problem hiding this comment.
4 Open source vulnerabilities detected - critical severity
Aikido detected 4 vulnerabilities across 1 package, it includes 1 critical and 3 high vulnerabilities.
Details
Remediation Aikido suggests bumping the vulnerable packages to a safe version.
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade dependencies to fix critical RCE vulnerability in lodash template injection via options.imports and prototype pollution. This update includes breaking changes that require manual migration.
uuid (8.3.2 => 14.0.0)
Where your code is affected: The
uuidpackage is used as a dependency ofaws-sdk(visible inpackage-lock.json). The action runs usingnode24(specified inaction.yml).Impact: The uuid v14 requires Node.js 20+ and expects
cryptoto be globally defined. While the action usesnode24which satisfies this requirement, the aws-sdk dependency uses uuid v8.0.0 internally. This version mismatch could cause issues if aws-sdk attempts to use uuid features that have changed. Additionally, uuid v12+ removed CommonJS support, which aws-sdk (a CommonJS package) may rely on.Remediation: The
package.jsonalready includes an override for uuid ("uuid@<=14.0.0": "14.0.0"), but this forces all uuid instances to v14. Consider removing this override to let aws-sdk use its compatible uuid version, or verify that aws-sdk v2.1354.0 is compatible with uuid v14.@octokit packages (multiple upgrades)
Where your code is affected:
src/gh.jslines 9, 22, 35: Usesgithub.getOctokit()which internally uses@octokit/requestThe bundled code in
dist/index.jsincludes agent configuration codeImpact:
All @octokit packages now require Node.js 18+ (the action uses node24, so this is satisfied)
@octokit/requestv8.0.0 removed the ability to pass custom request options except formethod,headers,body,signal,data. The code indist/index.jsshows agent configuration being passed to requests, which may no longer be supported.@octokit/endpointand@octokit/requestv8+ replaced Node.js http(s) Agents with fetch dispatchers.Remediation: Review the bundled
dist/index.jsto ensure no custom request options (likeagent) are being passed to Octokit requests. If proxy support is needed, migrate from Node.js Agents to fetch dispatchers as documented in the @octokit packages.All breaking changes by upgrading lodash from version 4.17.21 to 4.18.1 (CHANGELOG)
_.unset/_.omitnow blockconstructorandprototypeas non-terminal path keys unconditionally. Calls that previously returnedtrueand deleted the property now returnfalseand leave the target untouched._.templatenow throws"Invalid imports option passed into _.template"whenimportskeys contain forbidden identifier characters, which were previously allowed.All breaking changes by upgrading uuid from version 8.3.2 to 14.0.0 (CHANGELOG)
cryptois now expected to be globally defined (requires node@20+)v3(),v5(), andv6()now throw aRangeErrorifoffset < 0oroffset + 16 > buf.length✅ 8 CVEs resolved by this upgrade, including 1 critical 🚨 CVE
This PR will resolve the following CVEs:
linkheaders, allowing attackers to cause denial of service through specially crafted requests.