Explicitly error out on host-guest version mismatch#1252
Open
ludfjig wants to merge 1 commit intohyperlight-dev:mainfrom
Open
Explicitly error out on host-guest version mismatch#1252ludfjig wants to merge 1 commit intohyperlight-dev:mainfrom
ludfjig wants to merge 1 commit intohyperlight-dev:mainfrom
Conversation
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
ludfjig
added
the
kind/enhancement
ludfjig
requested review from
danbugs,
dblnz,
devigned,
jprendes,
marosset,
simongdavies and
syntactically
as code owners
dblnz
reviewed
Feb 24, 2026
Contributor
dblnz
left a comment
dblnz
left a comment
There was a problem hiding this comment.
This looks good, but do we want to match against the patch version also?
I think it would be better to ensure that the guest's major/minor are the same, but the patch version is greater or equal the host's version.
Contributor
Author
I thought about this, and then decided to be as conservative as possible, because this would limit some things we can update in patch versions. Maybe this is a good start, and then we can consider later whether we should relax it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hyperlight currently provides no backwards compatibility guarantees for guests. We should therefore error out explicitly if someone loads an old guest with new host, as they ABI might no longer match.
This PR enforces that hyperlight-host version must match the guest's hyperlight-guest-bin version.
Closes #845