Skip to content

feat(grpc): Plumb credentials in the channel#2550

Open
arjan-bal wants to merge 5 commits intohyperium:masterfrom
arjan-bal:integrate-channel-creds
Open

feat(grpc): Plumb credentials in the channel#2550
arjan-bal wants to merge 5 commits intohyperium:masterfrom
arjan-bal:integrate-channel-creds

Conversation

@arjan-bal
Copy link
Collaborator

@arjan-bal arjan-bal commented Mar 12, 2026

This PR has the following changes:

  • Have channel::new accept an Arc<C: ChannelCredentials> to enable using the same credentials, after type erasure, for out-of-band channels.
  • Have ChanneCredsInternal::connect accept references to some of its params to avoid cloning Arced values when possible.
  • Plumb credentials through the channel to the transport and have the tonic transport perform the security handshake.
  • Plumb call credentials through the channel and have the subchannel ensure correct security levels and add metadata.
  • Add a test for a TLS enabled gRPC client communicating with a TLS enabled tonic server.
  • In channel.rs, use the URL path to determine the authority instead of the URL authority. The URL authority is only meant to be used by name resolvers.

@arjan-bal arjan-bal changed the title feat(grpc): Plumb channel credentials in the channel feat(grpc): Plumb credentials in the channel Mar 12, 2026
@arjan-bal arjan-bal requested a review from dfawley March 12, 2026 19:23
@arjan-bal arjan-bal marked this pull request as draft March 13, 2026 14:18
@arjan-bal arjan-bal assigned arjan-bal and unassigned dfawley Mar 13, 2026
@arjan-bal arjan-bal force-pushed the integrate-channel-creds branch from 05947bc to 9cc6eda Compare March 13, 2026 16:59
@arjan-bal arjan-bal force-pushed the integrate-channel-creds branch from 56c746e to aef8fd9 Compare March 13, 2026 17:11
@arjan-bal arjan-bal marked this pull request as ready for review March 13, 2026 17:30
@arjan-bal arjan-bal assigned dfawley and unassigned arjan-bal Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants