Skip to content

[DOC] Add docstrings for best_estimator.py#235

Merged
SimonBlanke merged 2 commits intohyperactive-project:mainfrom
omkar-334:estimator-docs
Apr 22, 2026
Merged

[DOC] Add docstrings for best_estimator.py#235
SimonBlanke merged 2 commits intohyperactive-project:mainfrom
omkar-334:estimator-docs

Conversation

@omkar-334
Copy link
Copy Markdown
Contributor

Description

This PR adds docstrings for best_estimator.py, from https://github.com/scikit-learn/scikit-learn/blob/main/sklearn/model_selection/_search.py

Related Issues

Fixes #226

Type of Change

  • [BUG] - Bug fix (non-breaking change fixing an issue)
  • [ENH] - New feature (non-breaking change adding functionality)
  • [DOC] - Documentation changes
  • [MNT] - Maintenance

How was this solved?

Checklist

  • PR title includes appropriate tag: [BUG], [ENH], [DOC] or [MNT]
  • Linked to related issue (if applicable)
  • Code passes make check (lint, format, isort)

Note

@SimonBlanke make check is failing because of unused imports, unorganized imports and other issues... Can I take that up too?

Found 90 errors.
[*] 67 fixable with the `--fix` option (1 hidden fix can be enabled with the `--unsafe-fixes` option).
make: *** [lint] Error 1

Comment thread src/hyperactive/integrations/sklearn/best_estimator.py Outdated
Comment thread src/hyperactive/integrations/sklearn/best_estimator.py
Comment thread src/hyperactive/integrations/sklearn/best_estimator.py Outdated
@SimonBlanke
Copy link
Copy Markdown
Collaborator

make check is failing because of unused imports, unorganized imports and other issues... Can I take that up too?

@omkar-334 I would suggest you run it locally and look into the errors and understand them. If they are relevant or something should be changed you should open an issue for it 👍

@omkar-334
Copy link
Copy Markdown
Contributor Author

hey @SimonBlanke i've resolved your comments.

@omkar-334
Copy link
Copy Markdown
Contributor Author

cc @SimonBlanke

@SimonBlanke SimonBlanke merged commit 8dbb243 into hyperactive-project:main Apr 22, 2026
107 of 110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOC] Enhance BestEstimator docstrings

2 participants