chore: bump Go toolchain to 1.26.2 and update dependencies#86
Conversation
- Upgrade Go version from 1.26.1 to 1.26.2 across go.mod, Makefile,
Dockerfiles, .golangci.yaml, .project-settings.env, and the
pre-commit unit-test hook
- Bump sectools from v1.2.3 to v1.2.4 and update all import paths
from `pkg/io` to `pkg/iosec` (admin_artifact_store, admin_audit_archive,
admin_gateway, admin_job_event_store, cmd/worker-service/job_runner)
- Update indirect dependencies: golang.org/x/{net,sys,text} and
google.golang.org/genproto/googleapis/rpc to their latest patch releases
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s Go toolchain patch version and refreshes several dependencies, including migrating sectools import paths from pkg/io to pkg/iosec.
Changes:
- Bump Go version references from
1.26.1to1.26.2across build/lint tooling and Dockerfiles. - Upgrade
github.com/hyp3rd/sectoolstov1.2.4and update code imports topkg/iosec. - Update several indirect dependencies (notably
golang.org/x/*andgoogle.golang.org/genproto/...) and refresh pre-commit tooling.
Reviewed changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/worker/v1/worker.pb.go | Generated protobuf code updated; import formatting changed. |
| pkg/worker/v1/worker_grpc.pb.go | Generated gRPC stub updated; import formatting changed. |
| pkg/worker/v1/payload.pb.go | Generated protobuf code updated; import formatting changed. |
| pkg/worker/v1/admin.pb.go | Generated protobuf code updated; import formatting changed. |
| pkg/worker/v1/admin_grpc.pb.go | Generated gRPC stub updated; import formatting changed. |
| Makefile | Updates default Go toolchain version to 1.26.2. |
| go.mod | Sets Go version to 1.26.2; bumps sectools and indirect deps. |
| go.sum | Updates dependency checksums for bumped modules. |
| Dockerfile | Updates GO_VERSION build arg to 1.26.2. |
| Dockerfile.worker | Updates GO_VERSION build arg to 1.26.2. |
| .golangci.yaml | Updates configured Go version to 1.26.2. |
| .project-settings.env | Updates GO_VERSION to 1.26.2. |
| .pre-commit/unit-test-hook | Updates the toolchain version used by the hook to 1.26.2. |
| .pre-commit-config.yaml | Bumps cspell-cli pre-commit hook revision. |
| cspell.json | Adds iosec to dictionary to match new import path naming. |
| cmd/worker-service/job_runner.go | Switches sectools import from pkg/io to pkg/iosec. |
| admin_job_event_store.go | Switches sectools import from pkg/io to pkg/iosec. |
| admin_gateway.go | Switches sectools import from pkg/io to pkg/iosec. |
| admin_audit_archive.go | Switches sectools import from pkg/io to pkg/iosec. |
| admin_audit_archive_test.go | Switches sectools import from pkg/io to pkg/iosec. |
| admin_artifact_store.go | Switches sectools import from pkg/io to pkg/iosec. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| protoreflect "google.golang.org/protobuf/reflect/protoreflect" | ||
| protoimpl "google.golang.org/protobuf/runtime/protoimpl" | ||
| anypb "google.golang.org/protobuf/types/known/anypb" | ||
| durationpb "google.golang.org/protobuf/types/known/durationpb" | ||
| reflect "reflect" | ||
| sync "sync" | ||
| unsafe "unsafe" |
There was a problem hiding this comment.
The import block is no longer goimports-compliant (standard library imports like reflect/sync/unsafe should be grouped separately and placed before 3rd-party imports). With goimports enabled in golangci-lint, this will keep getting reformatted and may cause CI formatting diffs/failures; please run goimports (or golangci-lint --fix / make lint) on generated files after regeneration.
| protoreflect "google.golang.org/protobuf/reflect/protoreflect" | |
| protoimpl "google.golang.org/protobuf/runtime/protoimpl" | |
| anypb "google.golang.org/protobuf/types/known/anypb" | |
| durationpb "google.golang.org/protobuf/types/known/durationpb" | |
| reflect "reflect" | |
| sync "sync" | |
| unsafe "unsafe" | |
| reflect "reflect" | |
| sync "sync" | |
| unsafe "unsafe" | |
| protoreflect "google.golang.org/protobuf/reflect/protoreflect" | |
| protoimpl "google.golang.org/protobuf/runtime/protoimpl" | |
| anypb "google.golang.org/protobuf/types/known/anypb" | |
| durationpb "google.golang.org/protobuf/types/known/durationpb" |
| protoreflect "google.golang.org/protobuf/reflect/protoreflect" | ||
| protoimpl "google.golang.org/protobuf/runtime/protoimpl" | ||
| reflect "reflect" | ||
| sync "sync" | ||
| unsafe "unsafe" |
There was a problem hiding this comment.
The import block ordering/grouping is not goimports-compliant (3rd-party imports are mixed with stdlib without a separating blank line). Since goimports is enabled via golangci-lint, please run goimports (or golangci-lint --fix / make lint) so stdlib imports (reflect/sync/unsafe) are grouped separately above external imports.
| protoreflect "google.golang.org/protobuf/reflect/protoreflect" | |
| protoimpl "google.golang.org/protobuf/runtime/protoimpl" | |
| reflect "reflect" | |
| sync "sync" | |
| unsafe "unsafe" | |
| reflect "reflect" | |
| sync "sync" | |
| unsafe "unsafe" | |
| protoreflect "google.golang.org/protobuf/reflect/protoreflect" | |
| protoimpl "google.golang.org/protobuf/runtime/protoimpl" |
| protoreflect "google.golang.org/protobuf/reflect/protoreflect" | ||
| protoimpl "google.golang.org/protobuf/runtime/protoimpl" | ||
| reflect "reflect" | ||
| sync "sync" | ||
| unsafe "unsafe" |
There was a problem hiding this comment.
The import block ordering/grouping is not goimports-compliant (3rd-party imports are grouped together with stdlib imports). With goimports enabled in golangci-lint, please run goimports (or golangci-lint --fix / make lint) to restore standard import grouping (stdlib first, then external).
| protoreflect "google.golang.org/protobuf/reflect/protoreflect" | |
| protoimpl "google.golang.org/protobuf/runtime/protoimpl" | |
| reflect "reflect" | |
| sync "sync" | |
| unsafe "unsafe" | |
| reflect "reflect" | |
| sync "sync" | |
| unsafe "unsafe" | |
| protoreflect "google.golang.org/protobuf/reflect/protoreflect" | |
| protoimpl "google.golang.org/protobuf/runtime/protoimpl" |
| @@ -8,7 +8,6 @@ package workerpb | |||
|
|
|||
| import ( | |||
| context "context" | |||
There was a problem hiding this comment.
The blank line separating stdlib imports from external imports was removed. goimports (enabled via golangci-lint) will reintroduce the grouping; please run goimports (or golangci-lint --fix / make lint) to keep the generated file formatted consistently.
| context "context" | |
| context "context" |
| @@ -8,7 +8,6 @@ package workerpb | |||
|
|
|||
| import ( | |||
| context "context" | |||
There was a problem hiding this comment.
The blank line separating stdlib imports from external imports was removed. Since goimports runs in golangci-lint, please re-run goimports (or golangci-lint --fix / make lint) so the generated file matches the repo’s import grouping rules.
| context "context" | |
| context "context" |
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
pkg/iotopkg/iosec(admin_artifact_store, admin_audit_archive, admin_gateway, admin_job_event_store, cmd/worker-service/job_runner)