Merged
Conversation
Upgrade development tooling versions: - golangci-lint: v2.11.3 → v2.11.4 - buf: v1.66.1 → v1.67.0 Bump Go module dependencies: - go.opentelemetry.io/otel (and sdk, metric, trace): v1.42.0 → v1.43.0 - google.golang.org/grpc: v1.79.3 → v1.80.0 - gonum.org/v1/gonum: v0.16.0 → v0.17.0 - google.golang.org/genproto/googleapis/rpc: 20260319 → 20260401 Regenerate protobuf and gRPC Go stubs to reflect updated buf output: - Fix stdlib/external import grouping order across all pb.go files - Convert package-level var declarations to grouped var blocks - Add blank lines between UnimplementedServer method stubs in grpc files
There was a problem hiding this comment.
Pull request overview
This PR appears to support the new Admin UI feature by updating generated protobuf/gRPC Go code and refreshing toolchain/runtime dependencies (Go + Node), likely as part of a regeneration step (buf/protoc) and frontend dependency updates.
Changes:
- Regenerated/reformatted protobuf and gRPC Go stubs under
pkg/worker/v1/(import ordering, var block grouping, spacing). - Bumped Go tooling/runtime dependencies (golangci-lint, buf, otel, grpc, etc.).
- Updated Admin UI frontend lockfile dependencies.
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/worker/v1/worker.pb.go | Generated protobuf output formatting/structure changes (imports + var grouping). |
| pkg/worker/v1/worker_grpc.pb.go | Generated gRPC stub formatting (blank lines between methods). |
| pkg/worker/v1/payload.pb.go | Generated protobuf output formatting/structure changes (imports + var grouping). |
| pkg/worker/v1/admin.pb.go | Generated protobuf output formatting/structure changes (imports + var grouping). |
| pkg/worker/v1/admin_grpc.pb.go | Generated gRPC stub formatting (blank lines between methods). |
| Makefile | Bumps pinned tool versions for golangci-lint and buf. |
| go.mod | Updates module dependencies (otel metric/sdk metric, grpc, genproto). |
| go.sum | Updates checksum entries consistent with the Go module bumps. |
| admin-ui/package-lock.json | Refreshes locked frontend dependency graph (Next.js + lint/tooling deps). |
| .project-settings.env | Keeps tool version pins in sync with Makefile updates. |
| .pre-commit/golangci-lint-hook | Updates default golangci-lint version used by the pre-commit hook. |
Files not reviewed (1)
- admin-ui/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
5424
to
+5434
| "node_modules/resolve": { | ||
| "version": "1.22.11", | ||
| "resolved": "https://registry.npmjs.org/resolve/-/resolve-1.22.11.tgz", | ||
| "integrity": "sha512-RfqAvLnMl313r7c9oclB1HhUEAezcpLjz95wFH4LVuhk9JF/r22qmVP9AMmOU4vMX7Q8pN8jwNg/CSpdFnMjTQ==", | ||
| "version": "2.0.0-next.6", | ||
| "resolved": "https://registry.npmjs.org/resolve/-/resolve-2.0.0-next.6.tgz", | ||
| "integrity": "sha512-3JmVl5hMGtJ3kMmB3zi3DL25KfkCEyy3Tw7Gmw7z5w8M9WlwoPFnIvwChzu1+cF3iaK3sp18hhPz8ANeimdJfA==", | ||
| "dev": true, | ||
| "license": "MIT", | ||
| "dependencies": { | ||
| "es-errors": "^1.3.0", | ||
| "is-core-module": "^2.16.1", | ||
| "node-exports-info": "^1.6.0", | ||
| "object-keys": "^1.1.1", |
There was a problem hiding this comment.
resolve is now pinned to 2.0.0-next.6, which is a pre-release build. Since this is pulled in via eslint-import-resolver-node, please confirm this pre-release dependency is intentional; if not, consider pinning/overriding to a stable resolve release or using a resolver version that depends on a stable resolve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.