Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s dependency and tooling versions to keep the development and CI toolchain current.
Changes:
- Bump
golangci-lintversion fromv2.11.3tov2.11.4across Makefile, project settings, and pre-commit hook. - Update
bufversion in project settings fromv1.66.1tov1.67.0. - Upgrade
github.com/rs/zerologfromv1.34.0tov1.35.0(with correspondinggo.sumupdates).
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Makefile | Updates the GOLANGCI_LINT_VERSION used by make prepare-toolchain / make lint. |
| .project-settings.env | Updates pinned tool versions for CI/pre-commit settings loading. |
| .pre-commit/golangci-lint-hook | Updates the default golangci-lint version used by the hook. |
| go.mod | Bumps zerolog dependency version. |
| go.sum | Updates module checksums to match the dependency bump / tidy. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| GOLANGCI_LINT_VERSION=v2.11.3 | ||
| BUF_VERSION=v1.66.1 | ||
| GOLANGCI_LINT_VERSION=v2.11.4 | ||
| BUF_VERSION=v1.67.0 |
There was a problem hiding this comment.
BUF_VERSION is updated here, but it doesn’t appear to be referenced anywhere in the repo (e.g., CI workflows or scripts) to actually install/run buf. Either wire this variable into the tool installation steps (or a proto-related Makefile/pre-commit hook) or remove it to avoid a misleading/unused “toolchain” setting.
Suggested change
| BUF_VERSION=v1.67.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.