Skip to content

chore(android): update compileSdk to 35 and bump AndroidX dependencies#83

Merged
hyochan merged 2 commits intomainfrom
improvement/update-android-compilesdk-35
Mar 25, 2026
Merged

chore(android): update compileSdk to 35 and bump AndroidX dependencies#83
hyochan merged 2 commits intomainfrom
improvement/update-android-compilesdk-35

Conversation

@hyochan
Copy link
Member

@hyochan hyochan commented Mar 25, 2026

Summary

Updates the Android Google package to compile against API 35 (Android 15) and bumps several AndroidX dependencies to their latest stable versions.

Changes

SDK version:

  • compileSdk: 34 → 35

AndroidX dependencies:

  • androidx.core:core-ktx: 1.12.0 → 1.13.1
  • androidx.lifecycle:lifecycle-runtime-ktx: 2.7.0 → 2.8.7
  • androidx.lifecycle:lifecycle-viewmodel-ktx: 2.7.0 → 2.8.7

Why

  • Android 15 (API 35) has been stable since October 2024. Compiling against the latest SDK ensures new APIs are accessible and reduces deprecation warnings.
  • The AndroidX library updates bring bug fixes, performance improvements, and compatibility with API 35 changes (e.g. edge-to-edge display enforcement in core-ktx 1.13+).
  • minSdk remains at 23 for broad device support.

Summary by CodeRabbit

  • Chores
    • Updated Android SDK targets and refreshed core AndroidX libraries to ensure compatibility with newer Android platform versions and improve runtime stability across devices.

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Android project's compilation target to API 35 (Android 15) and refreshes key AndroidX libraries. These changes ensure compatibility with the latest Android platform features, provide access to new APIs, and incorporate bug fixes and performance improvements from updated dependencies, while maintaining broad device support by keeping the minSdk at 23.

Highlights

  • Android Compile SDK Update: The compileSdk version has been updated from 34 to 35, aligning the project with Android 15 (API 35).
  • AndroidX Dependency Bumps: Several AndroidX dependencies have been updated to their latest stable versions, including androidx.core:core-ktx to 1.13.1, androidx.lifecycle:lifecycle-runtime-ktx to 2.8.7, and androidx.lifecycle:lifecycle-viewmodel-ktx to 2.8.7.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4089abce-6339-4adf-a0a4-0fffa4a202c4

📥 Commits

Reviewing files that changed from the base of the PR and between d90822b and 7e85660.

📒 Files selected for processing (1)
  • packages/google/Example/build.gradle.kts
✅ Files skipped from review due to trivial changes (1)
  • packages/google/Example/build.gradle.kts

📝 Walkthrough

Walkthrough

Android build config updated in two Google modules: compileSdk raised to 35; targetSdk raised to 35 in the Example module; three AndroidX dependencies bumped (core-ktx 1.12.0→1.13.1, lifecycle-runtime 2.7.0→2.8.7, lifecycle-viewmodel variants 2.7.0→2.8.7).

Changes

Cohort / File(s) Summary
Google Android build files
packages/google/openiap/build.gradle.kts, packages/google/Example/build.gradle.kts
Bumped compileSdk to 35 (both) and targetSdk to 35 (Example). Updated AndroidX dependency versions: androidx.core:core-ktx 1.12.0→1.13.1; androidx.lifecycle:lifecycle-runtime-ktx 2.7.0→2.8.7; lifecycle ViewModel artifact(s) 2.7.0→2.8.7.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped through code with a twitchy nose,

Upgraded SDK where the wild compile grows.
Libraries sparkled, versions anew,
From thirty-four leaps to thirty-five view—
A tiny rabbit's celebratory chew. 🥕✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: updating compileSdk to 35 and bumping AndroidX dependencies across both build.gradle.kts files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch improvement/update-android-compilesdk-35

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the compileSdk version to 35 and several AndroidX dependencies (core-ktx, lifecycle-runtime-ktx, lifecycle-viewmodel-ktx) in the packages/google/openiap library's build.gradle.kts file. The review feedback highlights that the corresponding example application in packages/google/Example/ needs to have its compileSdk, targetSdk, and AndroidX dependencies updated to match the library's changes to ensure compatibility and proper testing with API 35.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
packages/google/openiap/build.gradle.kts (1)

81-82: Reduce version drift risk for AndroidX coordinates.

Lines 81-82 and Line 102 are correct, but consider centralizing these version strings (version catalog or local constants) so lifecycle-* stays synchronized during future bumps.

♻️ Suggested refactor
 dependencies {
-    implementation("androidx.core:core-ktx:1.13.1")
-    implementation("androidx.lifecycle:lifecycle-runtime-ktx:2.8.7")
+    val coreKtxVersion = "1.13.1"
+    val lifecycleVersion = "2.8.7"
+    implementation("androidx.core:core-ktx:$coreKtxVersion")
+    implementation("androidx.lifecycle:lifecycle-runtime-ktx:$lifecycleVersion")
@@
-    implementation("androidx.lifecycle:lifecycle-viewmodel-ktx:2.8.7")
+    implementation("androidx.lifecycle:lifecycle-viewmodel-ktx:$lifecycleVersion")
 }

Also applies to: 102-102

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@packages/google/openiap/build.gradle.kts` around lines 81 - 82, The AndroidX
version strings are hard-coded for
implementation("androidx.core:core-ktx:1.13.1") and
implementation("androidx.lifecycle:lifecycle-runtime-ktx:2.8.7") (and the other
lifecycle occurrence referenced) so centralize the version to avoid drift:
introduce a single lifecycleVersion constant (or add an entry to the version
catalog e.g. libs.versions.toml) and replace both lifecycle coordinates with the
interpolated coordinate (e.g.
"androidx.lifecycle:lifecycle-runtime-ktx:$lifecycleVersion") (and similarly
centralize core-ktx if desired), then update the other lifecycle dependency
referenced in the diff to use the same constant/catalog entry.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@packages/google/openiap/build.gradle.kts`:
- Around line 81-82: The AndroidX version strings are hard-coded for
implementation("androidx.core:core-ktx:1.13.1") and
implementation("androidx.lifecycle:lifecycle-runtime-ktx:2.8.7") (and the other
lifecycle occurrence referenced) so centralize the version to avoid drift:
introduce a single lifecycleVersion constant (or add an entry to the version
catalog e.g. libs.versions.toml) and replace both lifecycle coordinates with the
interpolated coordinate (e.g.
"androidx.lifecycle:lifecycle-runtime-ktx:$lifecycleVersion") (and similarly
centralize core-ktx if desired), then update the other lifecycle dependency
referenced in the diff to use the same constant/catalog entry.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 578d3797-4b47-48c5-a4b3-0c5fa4fb0fb5

📥 Commits

Reviewing files that changed from the base of the PR and between 740be5a and d90822b.

📒 Files selected for processing (1)
  • packages/google/openiap/build.gradle.kts

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@hyochan hyochan merged commit 546a0aa into main Mar 25, 2026
7 checks passed
@hyochan hyochan deleted the improvement/update-android-compilesdk-35 branch March 25, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant