[Job Launcher] Update job creation to use manifest JSON#3855
Open
[Job Launcher] Update job creation to use manifest JSON#3855
Conversation
added 6 commits
March 25, 2026 16:51
…on and old status handling
|
The latest updates on your projects. Learn more about Vercel for GitHub. 5 Skipped Deployments
|
flopez7
requested review from
Dzeranov and
portuu3
and removed request for
Copilot
portuu3
requested changes
Apr 6, 2026
| paymentCurrency: string, | ||
| paymentAmount: number | string, | ||
| escrowFundToken: string, | ||
| fundAmount: number, |
Collaborator
There was a problem hiding this comment.
You are passing 2 amounts now. Only 1 amount should be received then converted to fund token
| @ApiProperty({ name: 'manifest_hash' }) | ||
| @IsString() | ||
| @IsOptional() | ||
| @IsNotEmpty() |
Collaborator
There was a problem hiding this comment.
why have you changed this to be required?
| await this.manifestService.validateManifest( | ||
| requestType, | ||
| fundTokenAmount, | ||
| dto.manifest as ManifestDto, |
…nt and add it into JL server
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue tracking
#3806 #3864
Context behind the change
How has this been tested?
Ran and created fortune job locally
Release plan
None
Potential risks; What to monitor; Rollback plan
None