docs(cran): refresh cran-comments.md for the full v0.1.0 surface#40
Merged
Conversation
The Summary section had only mentioned the read surface plus the Tier 2 grab-bag (rendering, embedded images, Form XObjects, clip paths, document metadata). The actual v0.1.0 ships a complete mutation surface too: structural page edits, page-object styling + geometry rebuild, page-object creation (paths, rects, text, JPEG images), annotation authoring (14 subtypes), form filling + flattening, attachment authoring, and font loading (14 standard fonts + arbitrary TrueType / Type1 embedding). Rewrite the Summary to call this out as the second half of the package. Update the Expected NOTEs section to match what `R CMD check --as-cran` actually reports today: the Debian r-base default `-mno-omit-leaf-frame-pointer` compilation-flag NOTE is the only one currently observed; demote the previously-predicted "GNU make" and "Installed package size" NOTEs to "may appear" since they haven't materialised in the matrix. Add a "readwrite opt-in" line to the CRAN policy checklist — this is the key safety net for accidental mutation and worth calling out for reviewers. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Summary section had only mentioned the read surface plus the Tier 2 grab-bag (rendering, embedded images, Form XObjects, clip paths, document metadata). The actual v0.1.0 ships a complete mutation surface too: structural page edits, page-object styling
Update the Expected NOTEs section to match what
R CMD check --as-cranactually reports today: the Debian r-base default-mno-omit-leaf-frame-pointercompilation-flag NOTE is the only one currently observed; demote the previously-predicted "GNU make" and "Installed package size" NOTEs to "may appear" since they haven't materialised in the matrix.Add a "readwrite opt-in" line to the CRAN policy checklist — this is the key safety net for accidental mutation and worth calling out for reviewers.
What changed
Why
Test coverage
covr::package_coverage()).src/, the change runs cleanly under AddressSanitizer (.github/workflows/cpp-asan.yaml) and valgrind (.github/workflows/valgrind.yaml).API stability
Decision records
Checklist
pre-commit run --all-filespasses locally.R CMD check --as-cranis clean (0 errors / 0 warnings).devtools::document().NEWS.mdupdated under "(development version)".