Add trapezoidal time parameterization#437
Merged
Merged
Conversation
nim65s
approved these changes
May 13, 2026
florent-lamiraux
requested changes
May 13, 2026
Comment on lines
+60
to
+65
| /// Maximum velocity for each output degree of freedom. | ||
| value_type maxVelocity; | ||
| /// Maximum acceleration for each output degree of freedom. | ||
| value_type maxAcceleration; | ||
| /// Minimum duration assigned to each non-empty subpath. | ||
| value_type minimumDuration; |
Contributor
There was a problem hiding this comment.
To be consistent with the rest of the code, could you make the members private and add getter and setter methods ?
Contributor
Author
There was a problem hiding this comment.
i was taking example from simple-time-parametrization which works like this. Do you want to me to modify both?
Contributor
There was a problem hiding this comment.
I did not know it was like this in SimpleTimeParameterization. No need to modify for now.
florent-lamiraux
merged commit bd78bd9
into
humanoid-path-planner:devel
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.