Fix module-ci artifact name and add module-config input#1065
Open
mikelittle wants to merge 1 commit into
Open
Conversation
mikelittle
requested review from
ferschubert-hm,
filter182,
jerico,
vladislavhmn and
wisyhambolu
mikelittle
added a commit
to humanmade/altis-media
that referenced
this pull request
May 19, 2026
The acceptance tests in tests/acceptance/PrivateMediaCest.php require the private-media feature to be enabled in the test environment — the feature is opt-in and the file's docblock explicitly rejects per-test runtime injection. Pass the new `module-config` input on altis-dev-tools' Module CI workflow so the test root's composer.json has `extra.altis.modules.media.private-media = true`. Also temporarily pins the workflow to the humanmade/altis-dev-tools#1065 branch SHA where that input was added; re-point to @master (or the merge SHA) once #1065 lands. Also picks up the artifact-name slash fix from #1065, which is why the previous failed run could not even upload its codeception output. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Two fixes to module-ci.yml that surfaced when altis-media's first GHA
run failed Codeception:
1. Artifact upload now sanitises '/' out of the composer package name.
The previous template produced names like 'codecept-output-altis/media-php8.3',
which actions/upload-artifact@v4 rejects (forward slashes are not allowed
in artifact names). The step is `if: failure()`, so the bug only
surfaced when Codeception itself failed.
2. New optional `module-config` input lets a caller pass a JSON snippet
that is deep-merged into `extra.altis.modules` in the test-root
composer.json. Used to enable opt-in module features for the CI run
without per-test runtime injection — e.g. altis-media will pass
`{"media":{"private-media":true}}` so its acceptance tests can find
the private-media UI affordances.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mikelittle
force-pushed
the
fix-module-ci-artifact-name-and-module-config
branch
from
1cfc581 to
90a5e3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes to
module-ci.ymlthat surfaced when altis-media's first GHA run failed Codeception:/out of the composer package name. The previous template produced names likecodecept-output-altis/media-php8.3, whichactions/upload-artifact@v4rejects (forward slashes are not allowed in artifact names). The step isif: failure(), so the bug only surfaced when Codeception itself failed.module-configinput that deep-merges a caller-supplied JSON snippet intoextra.altis.modulesin the test-rootcomposer.json. Mirrors how the workflow already injects the cmsdefault-theme. Lets a caller enable opt-in module features for the CI run without per-test runtime injection — e.g. altis-media will pass{"media":{"private-media":true}}so its acceptance tests can find the private-media UI affordances.Refs humanmade/altis-media#458.
Test plan
module-config) and confirm:🤖 Generated with Claude Code