Skip to content

Add --method flag to import uploads (diff importer support) #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joehoyle wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add --method flag to import uploads (diff importer support) #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc27418
Add --method flag to import-uploads and fix got.stream crash
joehoyle May 8, 2026
8763d42
Add --method flag to import uploads and fix got.stream crash
joehoyle May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions lib/commands/stack/import.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,13 @@ const handler = async argv => {
if (argv.postSync) {
body.post_sync = true;
}
} else if (argv.uploadsPath) {
body.uploads_path = argv.uploadsPath;
} else {
if (argv.uploadsPath) {
body.uploads_path = argv.uploadsPath;
}
if (argv.method) {
body.method = argv.method;
}
}

const data = await fetchJSON(v, `stack/applications/${target}/${route}?stream=true`, {
Expand All @@ -78,6 +83,7 @@ export default {
.option('from', { type: 'string', description: 'Source application id.' })
.option('tables', { type: 'string', description: 'Comma-separated database table names.' })
.option('uploads-path', { type: 'string', description: 'Uploads prefix to import.' })
.option('method', { type: 'string', choices: ['diff', 'legacy'], description: 'Import method for uploads: diff skips unchanged files, legacy copies everything.' })
.option('replace', { type: 'string', array: true, description: 'Search-replace mapping from=to.' })
.option('use-mydumper', { type: 'boolean', description: 'Use mydumper/myloader.' })
.option('post-sync', { type: 'boolean', description: 'Run post-sync after database import.' })
Expand Down
2 changes: 1 addition & 1 deletion lib/stream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export default function(url, opts) {

buf = '';

stream = got.default.stream(url, reqOpts);
stream = got.stream(url, reqOpts);

onclose = once(() => {
if (destroyed) return;
Expand Down