Add a function to serialize MDBMinimalShard with a preset timestamp#796
Open
Add a function to serialize MDBMinimalShard with a preset timestamp#796
Conversation
sirahd
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be used in https://github.com/huggingface-internal/xetcas/pull/1015
Note
Medium Risk
Touches shard serialization/footer metadata and changes
serialize_implcall signatures, which could affect on-disk shard determinism and any callers relying on the previous timestamp behavior.Overview
Adds support for deterministic shard serialization by allowing
MDBMinimalShardto be serialized with a caller-provided creation timestamp.serialize_implnow accepts an optionaltimestampand uses it to populateMDBShardFileFooter.shard_creation_timestamp, while existing serialization paths continue to default tocurrent_timestamp; a newserialize_with_timestampAPI is added and existingserialize_*helpers are updated to pass the new parameter.Reviewed by Cursor Bugbot for commit 687a9bc. Bugbot is set up for automated code reviews on this repo. Configure here.