Skip to content

feat: expose CAS client factory and chunk cache re-exports#730

Open
XciD wants to merge 1 commit intomainfrom
adrien/expose-cas-client-factory
Open

feat: expose CAS client factory and chunk cache re-exports#730
XciD wants to merge 1 commit intomainfrom
adrien/expose-cas-client-factory

Conversation

@XciD
Copy link
Copy Markdown
Member

@XciD XciD commented Mar 18, 2026

Context

These changes support the hf-mount project, which needs direct access to CAS client types.

Summary

  • Changed create_remote_client visibility from pub(crate) to pub
  • Added re-exports for CasClient, ChunkCache, CacheConfig, and get_cache in xet_data::processing

@XciD XciD force-pushed the adrien/expose-cas-client-factory branch from ca07f71 to b094f21 Compare March 18, 2026 09:43
@XciD XciD marked this pull request as ready for review March 18, 2026 09:51
@XciD XciD requested review from hoytak and seanses March 18, 2026 09:51
Copy link
Copy Markdown
Collaborator

@rajatarya rajatarya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, minimal change — 4 lines to unblock hf-mount. A couple of thoughts:

API surface: This promotes create_remote_client and several xet_client types to the public API of xet_data. Once hf-mount depends on these re-exports, they become harder to change. Is there a reason hf-mount can't depend on xet_client directly instead of going through xet_data as a pass-through for types it doesn't own? If there is (e.g. TranslatorConfig coupling), worth a comment explaining the intent.

Client as CasClient rename: Reasonable ergonomic choice, but diverges from the name used everywhere else in xet-core internally. Just flagging — not blocking.

nit: create_remote_client is now pub with no doc comment. Since this is becoming part of the external-facing API for downstream consumers, a brief doc string would help future readers.

Overall: small and safe. The main question is architectural (direct dep vs re-export).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants