add lrz mirror workflow by greole · Pull Request #169 · hpsim/OGL

greole · 2026-04-04T07:53:57Z

This PR updates the github workflow and adds runs on LRZ hardware.

Copilot

Pull request overview

This PR introduces a GitHub Actions workflow that mirrors branches to an LRZ GitLab instance and triggers an LRZ GitLab CI pipeline intended to run tests on LRZ GPU hardware, alongside the corresponding GitLab CI configuration and helper scripts.

Changes:

Add LRZ GitLab CI configuration (.gitlab-ci.yml) with NVIDIA/AMD/Intel GPU job templates and build/test jobs.
Add GitHub Actions workflow to push to LRZ GitLab, trigger a pipeline, wait for completion, and attempt to cancel prior pipelines.
Add helper bash scripts for LRZ GitLab build/test, pipeline triggering/waiting/canceling; plus small REUSE and test-matrix updates.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
include/OGL/MatrixWrapper/HostMatrix.hpp	Fix typo in a comment.
ci/lrz-gitlab/build-and-test.sh	New vendor-specific build/test script for LRZ GitLab runners.
ci/github/wait_pipeline.sh	New script to poll LRZ GitLab pipeline status from GitHub Actions.
ci/github/trigger_pipeline.sh	New script to trigger LRZ GitLab pipelines with variables from GitHub Actions.
ci/github/cancel_triggered_pipelines.sh	New script intended to cancel running/pending LRZ GitLab pipelines before triggering new ones.
.reuse/dep5	Add REUSE metadata entry for the new GitHub workflow.
.gitlab-ci.yml	New LRZ GitLab CI pipeline definition for GPU builds/tests.
.github/workflows/trigger-lrz-gitlab-ci.yaml	New GitHub workflow to mirror to LRZ GitLab and orchestrate LRZ pipelines.
.github/workflows/test_matrix.json	Update OpenFOAM matrix version/path used by existing GitHub workflows.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-06T19:38:46Z

ci/lrz-gitlab/build-and-test.sh

+    export CXX_COMPILER_PATH="$(which g++)"
+    export CXX_SOURCE="${CXX_COMPILER_PATH%/*/*}"
+    export CXX_LIBDIR="${CXX_SOURCE}/lib64"
+    export LD_LIBRARY_PATH=${CXX_LIBDIR}:${LD_LIBRARY_PATH}


With set -u, this export will fail if LD_LIBRARY_PATH is unset in the job environment. Use a default (e.g., ${LD_LIBRARY_PATH:-}) and avoid producing a leading/trailing colon when empty.

Suggested change

export LD_LIBRARY_PATH=${CXX_LIBDIR}:${LD_LIBRARY_PATH}

export LD_LIBRARY_PATH="${CXX_LIBDIR}${LD_LIBRARY_PATH:+:${LD_LIBRARY_PATH}}"

Copilot · 2026-04-06T19:38:46Z

ci/github/trigger_pipeline.sh

+if [ $# -lt 1 ]; then
+  echo "Usage: $0 <branch>"
+  exit 1
+fi
+
+GROUP=greole
+HOST="gitlab-ce.lrz.de"
+PROJECT=$1
+BRANCH=$2
+CHECK_TOKEN=$3
+TRIGGER_TOKEN=$4
+shift 4
+VARIABLES="$@"     # Optional extra variables in the form: "variables[KEY]=VALUE"
+OGL_BRANCH="$BRANCH"


Argument validation/usage is inconsistent with how the script is actually parsed: the script reads $1..$4 (and shift 4) but only checks for at least 1 arg and the header comment says it takes only <branch>. Please update the usage + enforce the correct minimum argument count to avoid set -u crashes when called incorrectly.

Copilot · 2026-04-06T19:38:46Z

ci/github/trigger_pipeline.sh

+GROUP=greole
+HOST="gitlab-ce.lrz.de"
+PROJECT=$1
+BRANCH=$2
+CHECK_TOKEN=$3
+TRIGGER_TOKEN=$4


This script hardcodes GROUP and HOST instead of using LRZ_GROUP / LRZ_HOST from the environment (as described in the header comment and set in the GitHub Actions workflow). This makes the workflow configuration ineffective and harder to reuse across environments.

Copilot · 2026-04-06T19:38:46Z

ci/github/trigger_pipeline.sh

+# Prepare curl form data for variables
+FORM_DATA="--form ref=$BRANCH --form token=$TRIGGER_TOKEN"
+FORM_DATA="$FORM_DATA --form variables[OGL_BRANCH]=$OGL_BRANCH"
+
+for var in $VARIABLES; do
+  FORM_DATA="$FORM_DATA --form $var"
+done
+
+echo "FORM_DATA $FORM_DATA"
+
+response=$(curl -s --request POST $FORM_DATA \
+  "https://${HOST}/api/v4/projects/${GROUP}%2F${PROJECT}/trigger/pipeline")


echo "FORM_DATA $FORM_DATA" risks printing the trigger token into logs (and the token is also embedded in the curl args). Avoid logging secrets and pass curl form parameters without constructing a single string (use an array) to prevent accidental leaking and word-splitting issues.

Copilot · 2026-04-06T19:38:47Z

ci/github/cancel_triggered_pipelines.sh

+  if [[ "$PROJECT" == "NeoN" ]]; then
+    # Case 1: NeoN -> cancel all running/pending pipelines on the branch
+    echo "Cancelling pipeline $id (PROJECT=NeoN)..."
+    curl -s --request POST \
+      --header "PRIVATE-TOKEN: $TOKEN" \
+      "https://${LRZ_HOST}/api/v4/projects/${project_path}/pipelines/${id}/cancel" >/dev/null
+    continue
+  fi
+
+  if [[ "$PROJECT" == "NeoFOAM" ]]; then
+    # Case 2: NeoFOAM -> cancel only if TRIGGER_SOURCE == NeoN
+    vars=$(curl -s --header "PRIVATE-TOKEN: $TOKEN" \
+      "https://${LRZ_HOST}/api/v4/projects/${project_path}/pipelines/${id}/variables")
+
+    trigger_source=$(echo "$vars" | jq -r '.[] | select(.key=="TRIGGER_SOURCE") | .value' || true)
+
+    if [[ "$trigger_source" == "NeoN" ]]; then
+      echo "Cancelling pipeline $id (TRIGGER_SOURCE=NeoN)..."
+      curl -s --request POST \
+        --header "PRIVATE-TOKEN: $TOKEN" \
+        "https://${LRZ_HOST}/api/v4/projects/${project_path}/pipelines/${id}/cancel" >/dev/null
+    else
+      echo "Skipping pipeline $id (TRIGGER_SOURCE=$trigger_source)."
+    fi
+  fi


This canceller currently only cancels pipelines when PROJECT is exactly NeoN or NeoFOAM. In this repo's workflow it is invoked with PROJECT=ogl, so it will never actually cancel anything (but still prints success). Please add handling for ogl (or a default branch that cancels running/pending pipelines) so the GitHub workflow does what it intends.

Suggested change

if [[ "$PROJECT" == "NeoN" ]]; then

# Case 1: NeoN -> cancel all running/pending pipelines on the branch

echo "Cancelling pipeline $id (PROJECT=NeoN)..."

curl -s --request POST \

--header "PRIVATE-TOKEN: $TOKEN" \

"https://${LRZ_HOST}/api/v4/projects/${project_path}/pipelines/${id}/cancel" >/dev/null

continue

fi

if [[ "$PROJECT" == "NeoFOAM" ]]; then

# Case 2: NeoFOAM -> cancel only if TRIGGER_SOURCE == NeoN

vars=$(curl -s --header "PRIVATE-TOKEN: $TOKEN" \

"https://${LRZ_HOST}/api/v4/projects/${project_path}/pipelines/${id}/variables")

trigger_source=$(echo "$vars" | jq -r '.[] | select(.key=="TRIGGER_SOURCE") | .value' || true)

if [[ "$trigger_source" == "NeoN" ]]; then

echo "Cancelling pipeline $id (TRIGGER_SOURCE=NeoN)..."

curl -s --request POST \

--header "PRIVATE-TOKEN: $TOKEN" \

"https://${LRZ_HOST}/api/v4/projects/${project_path}/pipelines/${id}/cancel" >/dev/null

else

echo "Skipping pipeline $id (TRIGGER_SOURCE=$trigger_source)."

fi

fi

case "$PROJECT" in

NeoN|ogl)

# NeoN/ogl -> cancel all running/pending pipelines on the branch

echo "Cancelling pipeline $id (PROJECT=$PROJECT)..."

curl -s --request POST \

--header "PRIVATE-TOKEN: $TOKEN" \

"https://${LRZ_HOST}/api/v4/projects/${project_path}/pipelines/${id}/cancel" >/dev/null

;;

NeoFOAM)

# NeoFOAM -> cancel only if TRIGGER_SOURCE == NeoN

vars=$(curl -s --header "PRIVATE-TOKEN: $TOKEN" \

"https://${LRZ_HOST}/api/v4/projects/${project_path}/pipelines/${id}/variables")

trigger_source=$(echo "$vars" | jq -r '.[] | select(.key=="TRIGGER_SOURCE") | .value' || true)

if [[ "$trigger_source" == "NeoN" ]]; then

echo "Cancelling pipeline $id (TRIGGER_SOURCE=NeoN)..."

curl -s --request POST \

--header "PRIVATE-TOKEN: $TOKEN" \

"https://${LRZ_HOST}/api/v4/projects/${project_path}/pipelines/${id}/cancel" >/dev/null

else

echo "Skipping pipeline $id (TRIGGER_SOURCE=$trigger_source)."

fi

;;

*)

# Default -> cancel all running/pending pipelines on the branch

echo "Cancelling pipeline $id (default handling for PROJECT=$PROJECT)..."

curl -s --request POST \

--header "PRIVATE-TOKEN: $TOKEN" \

"https://${LRZ_HOST}/api/v4/projects/${project_path}/pipelines/${id}/cancel" >/dev/null

;;

esac

Copilot · 2026-04-06T19:38:47Z

.github/workflows/trigger-lrz-gitlab-ci.yaml

+      github.event_name != 'pull_request' ||
+      !contains(github.event.pull_request.labels.*.name, 'skip-build')


This workflow runs on pull_request events but requires secrets to push to LRZ and trigger pipelines; PRs from forks will not have access to these secrets and will fail. Add a guard to only run when the PR head repo matches the base repo (or otherwise skip fork PRs).

Suggested change

github.event_name != 'pull_request' ||

!contains(github.event.pull_request.labels.*.name, 'skip-build')

github.event_name != 'pull_request' || (

github.event.pull_request.head.repo.full_name == github.event.pull_request.base.repo.full_name &&

!contains(github.event.pull_request.labels.*.name, 'skip-build')

)

Copilot · 2026-04-06T19:38:47Z

.github/workflows/trigger-lrz-gitlab-ci.yaml

+          git fetch origin ${{ steps.branch.outputs.branch }}
+          git checkout -B ${{ steps.branch.outputs.branch }} origin/${{ steps.branch.outputs.branch }}
+          git reset --hard origin/${{ steps.branch.outputs.branch }}
+          git push --force lrz HEAD:refs/heads/${{ steps.branch.outputs.branch }}


git push --force to the LRZ mirror can overwrite remote history if there are unexpected updates on LRZ. Prefer --force-with-lease (or push to a dedicated CI ref namespace) to reduce the risk of clobbering concurrent/manual changes.

Suggested change

git push --force lrz HEAD:refs/heads/${{ steps.branch.outputs.branch }}

if git ls-remote --exit-code --heads lrz "${{ steps.branch.outputs.branch }}" >/dev/null 2>&1; then

git fetch lrz ${{ steps.branch.outputs.branch }}

git push --force-with-lease=refs/heads/${{ steps.branch.outputs.branch }} lrz HEAD:refs/heads/${{ steps.branch.outputs.branch }}

else

git push lrz HEAD:refs/heads/${{ steps.branch.outputs.branch }}

fi

Copilot · 2026-04-06T19:38:47Z

.github/workflows/trigger-lrz-gitlab-ci.yaml

+name: LRZ GitLab CI
+
+on:


Repository workflows consistently include SPDX headers (e.g. .github/workflows/format-check.yml:1-3), but this new workflow does not. Add the SPDX copyright and license header at the top so REUSE metadata is self-contained in the file like the others.

Copilot · 2026-04-06T19:38:47Z

.github/workflows/trigger-lrz-gitlab-ci.yaml

+      - name: Cancel running/pending NeoFOAM LRZ CI pipelines
+        run: |
+          ./ci/github/cancel_triggered_pipelines.sh \
+            "${{ env.OGL_REPO }}" \
+            "${{ steps.branch.outputs.branch }}" \
+            "${OGL_PROJECT_TOKEN}"


The step name mentions "NeoFOAM" but the script is invoked with the ogl project (env.OGL_REPO is set to ogl). Please rename this step (or fix the project argument) to avoid confusion when reading CI logs.

Copilot · 2026-04-06T19:38:48Z

.reuse/dep5

 License: GPL-3.0-or-later

+Files: .github/workflows/trigger-lrz-gitlab-ci.yaml
+Copyright: 2026 NeoN authors, 2026 ogl authors


Copyright holder casing is inconsistent with the rest of this file (uses "OGL authors" elsewhere). Consider changing "ogl authors" to "OGL authors" for consistency.

Suggested change

Copyright: 2026 NeoN authors, 2026 ogl authors

Copyright: 2026 NeoN authors, 2026 OGL authors

greole force-pushed the ci/lrz branch 15 times, most recently from 9f2439a to 499b648 Compare April 6, 2026 19:34

greole requested a review from Copilot April 6, 2026 19:34

Copilot started reviewing on behalf of greole April 6, 2026 19:35 View session

Copilot AI reviewed Apr 6, 2026

View reviewed changes

Add lrz mirror workflow

6e1b71e

greole force-pushed the ci/lrz branch from 499b648 to 6e1b71e Compare April 6, 2026 19:42

greole merged commit 15f81d2 into dev Apr 6, 2026
5 of 9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add lrz mirror workflow#169

add lrz mirror workflow#169
greole merged 1 commit intodevfrom
ci/lrz

greole commented Apr 4, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 6, 2026

Uh oh!

Copilot AI Apr 6, 2026

Uh oh!

Copilot AI Apr 6, 2026

Uh oh!

Copilot AI Apr 6, 2026

Uh oh!

Copilot AI Apr 6, 2026

Uh oh!

Copilot AI Apr 6, 2026

Uh oh!

Copilot AI Apr 6, 2026

Uh oh!

Copilot AI Apr 6, 2026

Uh oh!

Copilot AI Apr 6, 2026

Uh oh!

Copilot AI Apr 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	export LD_LIBRARY_PATH=${CXX_LIBDIR}:${LD_LIBRARY_PATH}
	export LD_LIBRARY_PATH="${CXX_LIBDIR}${LD_LIBRARY_PATH:+:${LD_LIBRARY_PATH}}"

		github.event_name != 'pull_request' \|\|
		!contains(github.event.pull_request.labels.*.name, 'skip-build')

-          git push --force lrz HEAD:refs/heads/${{ steps.branch.outputs.branch }}
+          if git ls-remote --exit-code --heads lrz "${{ steps.branch.outputs.branch }}" >/dev/null 2>&1; then
+            git fetch lrz ${{ steps.branch.outputs.branch }}
+            git push --force-with-lease=refs/heads/${{ steps.branch.outputs.branch }} lrz HEAD:refs/heads/${{ steps.branch.outputs.branch }}
+          else
+            git push lrz HEAD:refs/heads/${{ steps.branch.outputs.branch }}
+          fi

	Copyright: 2026 NeoN authors, 2026 ogl authors
	Copyright: 2026 NeoN authors, 2026 OGL authors

Conversation

greole commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

greole commented Apr 4, 2026 •

edited

Loading