Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
554 commits
Select commit Hold shift + click to select a range
c19a96a
format files
greole Oct 1, 2024
caeb435
various fixes
greole Oct 1, 2024
413cb36
consistent use of presets
greole Oct 1, 2024
db52b1c
fix get_local warning
greole Oct 1, 2024
eb78b7c
fix compiler warnings
greole Oct 1, 2024
e530cb3
consistent use of presets
greole Oct 1, 2024
f13e011
fix communicate values for fused update impl
greole Oct 9, 2024
70d5ca7
fix unit tests
greole Oct 10, 2024
baf7660
format files
greole Oct 10, 2024
5f8c077
removed unused
greole Oct 10, 2024
fb657bf
Merge pull request #154 from hpsim/fix/Repartitioner2D
greole Oct 10, 2024
23fc1df
unify write out, store matrix format as word, read writeGlobal
greole Oct 10, 2024
b3fb661
Merge remote-tracking branch 'origin/impl/integration_06' into stack/…
greole Oct 10, 2024
be0e907
wip convert_to_global
greole Oct 15, 2024
07dbaf5
wip convert_to_global
greole Oct 15, 2024
1c9a9ea
add documentation how to write out
greole Oct 15, 2024
7217e88
write out rhs
greole Oct 15, 2024
6b2678b
clean-up, write x
greole Oct 15, 2024
94e7ad1
rename solution to initial guess
greole Oct 15, 2024
d5774a0
allow multiple comm partners same rank
greole Oct 16, 2024
ecbb5a0
Merge pull request #156 from hpsim/enh/global_write
greole Oct 18, 2024
baf703f
wip add all interface to sparsity pattern
greole Oct 18, 2024
283263a
format files
greole Oct 26, 2024
9a95585
add output on failure
greole Nov 2, 2024
6bdcdea
allow mpirun as root
greole Nov 2, 2024
7ba208f
fix validate.py license
greole Nov 2, 2024
f7c82d3
fix issue with missing interface element
greole Nov 5, 2024
3921560
make it "libOGL.so"
greole Nov 5, 2024
36e7c56
clean-up
greole Nov 5, 2024
bf1d151
add l2d and p2d test cases
greole Nov 5, 2024
1261b32
fix typo
greole Nov 5, 2024
4f66c84
update p2d test case
greole Nov 6, 2024
e15eee3
fix local and non-local sparsity for local interfaces
greole Nov 7, 2024
c27cb81
fix count of interface elments
greole Nov 7, 2024
efbea67
fix mapping in the interface case
greole Nov 7, 2024
5c3ecc7
fix local sparsity length issue
greole Nov 7, 2024
ac57432
fix local sparsity length issue
greole Nov 7, 2024
402cd08
fix issue with wrong local matrix nnz for distributed update, add mor…
greole Nov 8, 2024
f9db625
improve error message
greole Nov 8, 2024
19a84ed
fix issue with wrong data access for empty cyclic bcs
greole Nov 8, 2024
c7f7db6
add non local row and col test
greole Nov 8, 2024
e01f9c0
wip fix fused interface case
greole Nov 8, 2024
bcca23a
wip fix fused interface case, add unit test
greole Nov 8, 2024
b36a1e5
fix issue that same processor appears multiple times in communication…
greole Nov 11, 2024
905c8b6
wip add more unit tests
greole Nov 12, 2024
9e30d41
wip add more unit tests
greole Nov 12, 2024
ec096e3
refactor interface handling
greole Nov 12, 2024
34de3f0
udate p2ds2x2 test
greole Nov 26, 2024
b2ff078
remove deprecated unittest
greole Nov 27, 2024
0c0d548
fix repartitioner, add 1d test case
greole Nov 27, 2024
a655db0
remove unused travis file
greole Nov 27, 2024
be8167e
fix typo
greole Nov 27, 2024
8fae283
update Repartitioner1D/2D cases
greole Nov 27, 2024
8274048
format files
greole Nov 27, 2024
ff6af56
update _typos file
greole Nov 27, 2024
d22b0be
add 1d mapping test
greole Nov 28, 2024
f747d46
wip fix collective vs pairwise comm
greole Nov 29, 2024
5ac4519
wip use global ids for interfaces
greole Nov 29, 2024
87ae15f
wip fix collective vs pairwise comm
greole Dec 2, 2024
18bc2b0
wip reorder map
greole Dec 2, 2024
c3d9a25
format
greole Dec 2, 2024
6e1f857
remove unneeded file
greole Dec 2, 2024
7889eba
fix udate of matrix coefficients
greole Dec 2, 2024
6e9ad51
add global write out
greole Dec 3, 2024
aafb71b
update unit test
greole Dec 3, 2024
d6a8df3
fix hostbuffer implementation and vector update
greole Dec 4, 2024
0e81056
format
greole Dec 4, 2024
66a5d1f
format
greole Dec 4, 2024
27d2083
[interface] use common .cpp filenames
greole Dec 5, 2024
15b1cd1
[interface] restructure solver
greole Dec 5, 2024
b7904b6
wip start moving distributed test data
greole Dec 6, 2024
21ae6a0
fixup!
greole Dec 6, 2024
e889605
fix typo
greole Dec 9, 2024
d2b5e5f
change test folder layout
greole Dec 9, 2024
01d8a1e
update integration test folder
greole Dec 9, 2024
a3cec09
fix typo
greole Dec 9, 2024
d568120
trigger ci
greole Dec 9, 2024
597a662
add new integration test
greole Dec 9, 2024
278f859
move more data to DistributedData.hpp
greole Dec 9, 2024
0cb1154
fixup distributed test, read name from unit ptr
greole Dec 9, 2024
ac8a74f
clean-up
greole Dec 9, 2024
18d3bf7
change integration test case to l2d
greole Dec 9, 2024
7114b2f
Merge pull request #157 from hpsim/fix/cyclic_bcs
greole Dec 9, 2024
1f691c5
Merge branch 'dev' into stack/ogl_0.6
greole Dec 9, 2024
a0d8568
fixup!
greole Dec 10, 2024
acca0d2
fixup remove unneeded sleep
greole Dec 10, 2024
05b2067
fixup!
greole Dec 10, 2024
056663e
fixup vector update
greole Dec 11, 2024
0ec5ae4
fix compress columns order based on orig ranks instead of interface id
greole Dec 11, 2024
2a7b8b2
fix compress cols based on global column
greole Dec 11, 2024
e06b0d0
fix send and receive order for repartitioned cases
greole Dec 11, 2024
4c84cc4
fix send_ptr, recv_ptr for fused interfaces
greole Dec 12, 2024
2dc800e
fix order of send_ptr, recv_ptr for fused interfaces
greole Dec 13, 2024
596b0af
format
greole Dec 13, 2024
044134a
format
greole Dec 13, 2024
233cbc4
format
greole Dec 13, 2024
d3cb686
move to new Ginkgo version
greole Dec 13, 2024
0ec5e42
cleanup
greole Dec 13, 2024
714a84f
changes related to fuse fix
greole Dec 13, 2024
1711fd5
remove libs(libOGL.so) since we link with OGL.so otherwise we get a d…
greole Dec 13, 2024
c5c37f3
fix warning about read ctr on geometric field
greole Dec 13, 2024
ac82dd9
deactivate failing cyclic tests for now
greole Dec 13, 2024
cc7e3f0
replace std::partial_sum implementation since it seems to fail random…
greole Dec 13, 2024
7247c84
cleanup
greole Dec 13, 2024
0ae0935
deactivate failing cyclic tests for now
greole Dec 13, 2024
0ef6662
format
greole Dec 13, 2024
1b9b621
fixup back to orig_rank based column compression
greole Dec 14, 2024
8a9b572
Merge remote-tracking branch 'origin/stack/ogl_0.6' into stack/ogl_0.6
greole Dec 14, 2024
1f1962e
use orig comm rank for compression
greole Dec 15, 2024
1327943
log device id
greole Dec 15, 2024
c25d150
clean-up
greole Dec 16, 2024
393210a
improve output
greole Dec 16, 2024
1702287
fix Repartitioner unit tst
greole Dec 16, 2024
09998af
add dimension set ds again since read ctr fails for cyclic bcs
greole Dec 16, 2024
ba0bb13
use host buffer also for pairwise recv
greole Dec 17, 2024
c2d45b3
fixup! format
greole Dec 17, 2024
c8f564e
fixup!
greole Dec 19, 2024
846cc0a
Merge remote-tracking branch 'origin/stack/ogl_0.6' into stack/ogl_0.6
greole Dec 19, 2024
3c1f190
distinguish between GDR calls need host buffer and xRank communicatio…
greole Jan 21, 2025
a97e8a9
refactor communicator handling
greole Jan 26, 2025
83767af
refactor communicator handling
greole Jan 26, 2025
e12058f
apply only on active ranks
greole Jan 26, 2025
d9bb778
call solve only on active ranks
greole Jan 27, 2025
5279922
fix formating of create msg
greole Jan 29, 2025
ec80ec8
update Readme
greole Jan 29, 2025
c59798c
format
greole Jan 29, 2025
aeeb05b
use global ids for cyclic patches
greole Jan 29, 2025
78b7ba8
skip inactive ranks only if splitComm is active
greole Jan 31, 2025
26f98a0
Merge pull request #158 from hpsim/impl/split_comm
greole Jan 31, 2025
b90af91
fixup base sorting on comm_ranks instead of interfaces
greole Feb 2, 2025
6932c08
improve output
greole Feb 2, 2025
c577ed5
Merge remote-tracking branch 'origin/stack/ogl_0.6' into stack/ogl_0.6
greole Feb 3, 2025
c4580bd
make compression order consisteent, fix issue with host_rank
greole Feb 3, 2025
2421a00
improve docstring
greole Feb 5, 2025
75621e4
Merge remote-tracking branch 'origin/stack/ogl_0.6' into stack/ogl_0.6
greole Feb 5, 2025
ac2d568
add consecutivity check
greole Feb 5, 2025
a993dcb
Merge remote-tracking branch 'origin/stack/ogl_0.6' into stack/ogl_0.6
greole Feb 5, 2025
5ba05c0
format
greole Feb 5, 2025
f784c7b
fixup! consecutivity check range
greole Feb 6, 2025
0d3a0fc
update README
greole Feb 6, 2025
e630010
update Readme, add ranksPerGPU
greole Feb 7, 2025
fdea28e
fix compression based on orig_comm_ranks
greole Feb 7, 2025
f2f631c
fix typo MTI->MPI
greole Feb 7, 2025
875de27
add BiCGStab and GMRES again
greole Feb 7, 2025
dc458e3
add multigrid
greole Feb 7, 2025
3e71e80
add some comments
greole Feb 7, 2025
14709c0
Merge remote-tracking branch 'origin/stack/ogl_0.6' into stack/ogl_0.6
greole Feb 7, 2025
f7d8d40
format files
greole Feb 7, 2025
10ced59
prepare changes for distmg
greole Feb 17, 2025
9e9d333
refactor solver generation
greole Feb 17, 2025
1c8d63b
add BiCGStab/GMRES changes
greole Feb 17, 2025
6fbc94a
fixup!
greole Feb 17, 2025
4597a91
fixup
greole Feb 17, 2025
2c1637c
add distributed multigrid solver and preconditioner
greole Feb 17, 2025
04862e4
Merge pull request #159 from hpsim/fix/mg
greole Feb 17, 2025
192d943
update preconditioner settings
greole Feb 18, 2025
1c5ea63
fix cg valuetype
greole Feb 18, 2025
1584dea
Merge pull request #160 from hpsim/fix/mg
greole Feb 18, 2025
feb838b
update precond
greole Feb 19, 2025
e059e31
improve executor allocation output
greole Feb 19, 2025
24395e4
improve output
greole Feb 19, 2025
7e067a7
fixup! format files, update multigrid
greole Feb 19, 2025
eb16448
improve precond output
greole Feb 20, 2025
be28095
improve output add consistency check
greole Feb 20, 2025
92d4a6b
add consistent interface sorting
greole Feb 22, 2025
dee12aa
format files
greole Feb 27, 2025
8a50ce5
sort send_idxs by default on creation in host mtx
greole Feb 27, 2025
42a3293
fixup!
greole Feb 28, 2025
f159247
always compute repartitioned comm pattern
greole Apr 4, 2025
de73049
clean-up
greole Apr 4, 2025
a14bb6a
add todo note
greole May 13, 2025
504d8f7
add std::filesystem::create again
greole May 13, 2025
816e288
clean-up
greole May 13, 2025
92d7cea
Merge pull request #161 from hpsim/fix/multinode-issues
greole May 13, 2025
c0898e8
format
greole May 13, 2025
e622f3e
wip add ell
greole May 30, 2025
cec1050
create device executor only on owning ranks
greole May 30, 2025
dea2f47
add call to compute pad
greole May 30, 2025
a78058a
wip update ell update procedure
greole May 31, 2025
981731f
make non local a coo matrix
greole Jun 1, 2025
a715fcc
wip
greole May 30, 2025
49ba1be
clean-up
greole May 31, 2025
ed8bc7d
call ell update
greole May 31, 2025
4222ac9
wip debug ell
greole Jun 1, 2025
acf61df
wip update
greole Jun 2, 2025
ac34224
wip fixup! ell is col ordered
greole Jun 2, 2025
1c753fe
wip ell padding
greole Jun 2, 2025
48f0957
add sort col major option
greole Jun 2, 2025
6e4ec33
wip ell mapping
greole Jun 3, 2025
9f66d63
format
greole Jun 3, 2025
ba31a66
fix hanging LOG
greole Jun 4, 2025
7508266
clean-up!
greole Jun 4, 2025
bf543ba
format
greole Jun 4, 2025
c248d2d
clean-up
greole Jun 4, 2025
9894163
typo
greole Jun 4, 2025
49abfa9
Merge pull request #162 from hpsim/fix/ell
greole Jun 4, 2025
6580221
wip use index_map
greole Jun 5, 2025
919e14b
fix rank for recv_connections
greole Jun 6, 2025
ba8c029
fix non local dimension
greole Jun 6, 2025
f3a8c23
use old gko version
greole Jun 6, 2025
00ca3ff
format!
greole Jun 6, 2025
215c1c7
fixup!
greole Jun 7, 2025
6cd7fc0
improve hip executor output
greole Jun 22, 2025
1f6bcc3
clean-up preconditioner
greole Jun 22, 2025
8dd8001
add pipecg
greole Jun 22, 2025
8faf86b
add pipecg
greole Jun 22, 2025
365c42c
format
greole Jun 22, 2025
5b08cfe
add reduction factor
greole Jun 22, 2025
7b7b503
add pipecg
greole Jun 22, 2025
9e7f13f
fix repeated comm splitting
greole Jun 28, 2025
d35fbe6
add (S)SOR smoother
greole Jul 5, 2025
607c7cf
format
greole Jul 8, 2025
f977c47
Merge branch 'stack/ogl_0.6' into fix/ginkgo110
greole Jul 8, 2025
99442cb
fix typos
greole Jul 8, 2025
75232aa
make unitialized comm error more descriptive
greole Jul 9, 2025
a66e462
fix casting warnings
greole Jul 9, 2025
98972fb
fix failing tests, init device comm, support only fused for now
greole Jul 9, 2025
acc9271
clean-up
greole Jul 9, 2025
6b883bc
fix foundation version build issue, fix warnings
greole Jul 9, 2025
e6d0064
fix foundation version build issue, fix warnings
greole Jul 9, 2025
754b787
remove foundation workflow for now
greole Jul 14, 2025
0ab62c2
change foam lib dir cache
greole Jul 14, 2025
e9336d7
fix type conversion issues
greole Jun 28, 2025
3162de6
make it more verbose
greole Jul 15, 2025
5a3e6a9
make coarse solver selectable
greole Jul 17, 2025
4351115
update defaults
greole Jul 24, 2025
a7e9ebd
format
greole Jul 24, 2025
512069b
simplify for now
greole Jul 24, 2025
c3c758a
simplify for now
greole Jul 24, 2025
94ea609
update time
greole Jul 28, 2025
2985e3b
export matrices
greole Jul 28, 2025
b300634
relax bounds
greole Jul 28, 2025
75f1ab2
Merge pull request #163 from hpsim/fix/ginkgo110
greole Jul 28, 2025
2879ee5
empty
greole Jul 28, 2025
321cd46
fixup
greole Jul 28, 2025
2c600de
fix path
greole Jul 29, 2025
7feeea8
relax bounds
greole Jul 29, 2025
2680d44
relax bounds
greole Jul 29, 2025
1a9b025
add more verbose message
greole Jul 29, 2025
fd83689
simplify
greole Jul 29, 2025
4bf3b04
update defaults
greole Jul 29, 2025
ae2c4b5
format, fix typo
greole Jul 29, 2025
bfa709a
fixup
greole Jul 29, 2025
ed91c9e
fixup host buffer force, format
greole Jul 29, 2025
ab97bf9
format
greole Aug 4, 2025
acbdab8
init comm
greole Aug 4, 2025
3371847
init gko comm
greole Aug 4, 2025
a218b1e
fixup clang tidy .C -> .cpp
greole Aug 5, 2025
7d2c83e
Merge pull request #164 from hpsim/fix/workflow
greole Aug 5, 2025
97de3d3
remove broken aws workflow
greole Sep 25, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 0 additions & 1 deletion .clang-format
Original file line number Diff line number Diff line change
Expand Up @@ -109,4 +109,3 @@ Standard: Cpp11
TabWidth: 8
UseTab: Never
...

8 changes: 3 additions & 5 deletions .cmake-format.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# SPDX-License-Identifier: Unlicense
# SPDX-FileCopyrightText: 2024 OGL authors
#
# SPDX-License-Identifier: GPL-3.0-or-later

# ----------------------------------
# Options affecting listfile parsing
Expand Down Expand Up @@ -29,7 +28,7 @@
disable = False

# How wide to allow formatted cmake files
line_width = 80
line_width = 100

# How many spaces to tab for indent
tab_size = 2
Expand Down Expand Up @@ -168,7 +167,7 @@
with section("lint"):

# a list of lint codes to disable
disabled_codes = []
disabled_codes = ["C0103"]

# regular expression pattern describing valid function names
function_pattern = '[0-9a-z_]+'
Expand Down Expand Up @@ -242,4 +241,3 @@
# A dictionary containing any per-command configuration overrides. Currently
# only `command_case` is supported.
per_command = {}

31 changes: 12 additions & 19 deletions .github/workflows/build-foam.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ defaults:

on:
push:
branches:
branches:
- dev
- main
pull_request:
Expand Down Expand Up @@ -41,7 +41,7 @@ jobs:
- name: Set matrix data
id: set-matrix
run: |
pwd
pwd
echo "matrix=$(jq -c . < .github/workflows/test_matrix.json)" >> $GITHUB_OUTPUT
build:
Expand All @@ -58,23 +58,22 @@ jobs:
- name: Get Ginkgo checkout version
shell: bash
run: |
grep -A1 "set(GINKGO_CHECKOUT_VERSION" CMakeLists.txt|tail -n1|grep -o "[0-9a-z\-]*" > GINKGO_CHECKOUT_VERSION
grep -A1 "set(GINKGO_CHECKOUT_VERSION" CMakeLists.txt|tail -n1|grep -o "[0-9a-z\-_.]*" > GINKGO_CHECKOUT_VERSION
export GINKGO_CHECKOUT_VERSION=$(cat GINKGO_CHECKOUT_VERSION)
echo "GINKGO_CHECKOUT_VERSION=$GINKGO_CHECKOUT_VERSION" >> $GITHUB_ENV
- name: Cache build folder
uses: actions/cache@v4
if: ${{!contains(github.event.pull_request.labels.*.name, 'Skip-cache')}}
with:
key: build-${{ matrix.OF.path }}-${{env.GINKGO_CHECKOUT_VERSION}}
path: |
${{github.workspace}}/build
key: build_PR_${{ github.event.pull_request.number }}_${{matrix.OF.path}}
path: ${{github.workspace}}/build

- name: Cache FOAM_USER_LIBBIN
uses: actions/cache@v4
with:
key: FOAM_USER_LIBBIN-${{ matrix.OF.version }}-${{ github.sha }}
path: |
${{matrix.OF.foam_user_libbin}}
key: FOAM_USER_LIBBIN-${{ matrix.OF.version }}-${{ github.sha }}
path: ${{matrix.OF.foam_user_libbin}}

- name: Configure CMake
# Use a bash shell so we can use the same syntax for environment variable
Expand All @@ -83,25 +82,19 @@ jobs:
run: |
source /root/OpenFOAM/${{matrix.OF.path}}/etc/bashrc
mkdir -p ${{matrix.OF.foam_user_libbin}}
mkdir -p build
cd build
[ -d "/github/home/$GINKGO_CHECKOUT_VERSION" ] && cp -rp /github/home/$GINKGO_CHECKOUT_VERSION third_party
cmake -GNinja -DOGL_ALLOW_REFERENCE_ONLY=On -DOGL_BUILD_UNITTEST=ON -DCMAKE_BUILD_TYPE=$BUILD_TYPE -DCMAKE_INSTALL_PREFIX=${{matrix.OF.foam_user_libbin}} ..
cmake --preset develop
- name: Build OGL
working-directory: ${{github.workspace}}/build
working-directory: ${{github.workspace}}
run: |
source /root/OpenFOAM/${{matrix.OF.path}}/etc/bashrc
cmake --build . --config $BUILD_TYPE
cmake --build --preset develop
- name: Install OGL
working-directory: ${{github.workspace}}
run: |
source /root/OpenFOAM/${{matrix.OF.path}}/etc/bashrc
cmake --install ./build
ls $FOAM_USER_LIBBIN
ls ${{matrix.OF.foam_user_libbin}}
cmake --build --preset develop --target install
- name: Check folders
working-directory: ${{github.workspace}}
Expand Down
152 changes: 0 additions & 152 deletions .github/workflows/compile_on_aws.yml

This file was deleted.

4 changes: 2 additions & 2 deletions .github/workflows/format-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,5 @@ jobs:
- name: check for todo fixme note
run: |
NTODOS="$(grep -r 'TODO DONT MERGE' --exclude-dir=.github | wc -l)"
echo "Found $NTODOS TODO DONT MERGE notes"
! grep -q -r "TODO DONT MERGE" --exclude-dir=.github
echo "Found $NTODOS TODO DONT MERGE notes"
! grep -q -r "TODO DONT MERGE" --exclude-dir=.github
Loading