Skip to content

feat(editor): time based image overlays#89

Open
ekuleshov wants to merge 2 commits intohm21:stablefrom
ekuleshov:time-based-image-overlays
Open

feat(editor): time based image overlays#89
ekuleshov wants to merge 2 commits intohm21:stablefrom
ekuleshov:time-based-image-overlays

Conversation

@ekuleshov
Copy link

PR Checklist (Required)

Please ensure your PR meets the following requirements:

  • The commit message follows our guidelines: https://github.com/hm21/pro_image_editor/blob/stable/CONTRIBUTING.md#style-guides
  • I have run dart format . in the terminal and committed any changes.
  • I have run dart analyze . in the terminal and addressed any issues.
  • I have run flutter test in the terminal and addressed any issues.
  • I have pulled from the stable branch before committing.
  • I have updated the CHANGELOG.md file with my changes (For the version, you can use X.X.X, I will later bump it after it's merged).
  • The PR title follows the conventional commit style (e.g., feat(paint-editor): add new triangle shape).
  • If this PR introduces breaking changes, I have verified that there is no way to implement the changes without them.

PR Checklist (Optional)

  • Tests have been added for the changes.
  • Documentation has been added/updated.

PR Type

Please indicate the types of changes this PR introduces by checking the relevant boxes:

  • Bugfix
  • Feature
  • Performance
  • Refactor (no functional or API changes)
  • Code style updates (e.g., formatting, local variables)
  • Documentation updates
  • CI-related changes
  • Other... Please describe:

Current Behavior

Issue Number: N/A

New Behavior

Breaking Changes?

Does this PR introduce a breaking change?

  • Yes
  • No

Additional Information

Based on the discussion at #53 (reply in thread)

I replaced image overlay in the example app with time based overlay.
The example app works on Android. I am unable to run iOS and macos builds due to recent changes in the pro_image_editor see a bit more info in #88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant