Skip to content

fix: remove hidden BottomAppBar SafeArea gap in sub-editors #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hm21 merged 3 commits into from
Mar 23, 2026
Merged

fix: remove hidden BottomAppBar SafeArea gap in sub-editors #791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ac379a
fix: remove hidden BottomAppBar SafeArea gap in sub-editors
faizahmaddae Mar 17, 2026
f815a0a
Merge branch 'stable' into fix/sub-editor-bottom-bar-gap
faizahmaddae Mar 17, 2026
cf8688a
style: fix dart format in crop_rotate_editor.dart
faizahmaddae Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions lib/features/blur_editor/blur_editor.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,11 +256,15 @@ class BlurEditorState extends State<BlurEditor>
right: blurEditorConfigs.safeArea.right,
child: RecordInvisibleWidget(
controller: screenshotCtrl,
child: Scaffold(
backgroundColor: blurEditorConfigs.style.background,
appBar: _buildAppBar(),
body: _buildBody(),
bottomNavigationBar: _buildBottomNavBar(),
child: MediaQuery.removePadding(
context: context,
removeBottom: !blurEditorConfigs.safeArea.bottom,
child: Scaffold(
backgroundColor: blurEditorConfigs.style.background,
appBar: _buildAppBar(),
body: _buildBody(),
bottomNavigationBar: _buildBottomNavBar(),
),
),
),
),
Expand Down
28 changes: 16 additions & 12 deletions lib/features/crop_rotate_editor/crop_rotate_editor.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2146,20 +2146,24 @@ class CropRotateEditorState extends State<CropRotateEditor>
preferBelow: true,
),
),
child: Scaffold(
resizeToAvoidBottomInset: false,
backgroundColor: cropRotateEditorConfigs.style.background,
appBar: _buildAppBar(constraints),
body: Center(
child: SizedBox(
width:
constraints.maxWidth *
(cropRotateEditorConfigs.maxWidthFactor ??
(!kIsWeb && Platform.isAndroid ? 0.9 : 1)),
child: _buildBody(),
child: MediaQuery.removePadding(
context: context,
removeBottom: !cropRotateEditorConfigs.safeArea.bottom,
child: Scaffold(
resizeToAvoidBottomInset: false,
backgroundColor: cropRotateEditorConfigs.style.background,
appBar: _buildAppBar(constraints),
body: Center(
child: SizedBox(
width:
constraints.maxWidth *
(cropRotateEditorConfigs.maxWidthFactor ??
(!kIsWeb && Platform.isAndroid ? 0.9 : 1)),
child: _buildBody(),
),
),
bottomNavigationBar: _buildBottomAppBar(),
),
bottomNavigationBar: _buildBottomAppBar(),
),
),
);
Expand Down
14 changes: 9 additions & 5 deletions lib/features/filter_editor/filter_editor.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,11 +309,15 @@ class FilterEditorState extends State<FilterEditor>
right: filterEditorConfigs.safeArea.right,
child: RecordInvisibleWidget(
controller: screenshotCtrl,
child: Scaffold(
backgroundColor: filterEditorConfigs.style.background,
appBar: _buildAppBar(),
body: _buildBody(),
bottomNavigationBar: _buildBottomNavBar(),
child: MediaQuery.removePadding(
context: context,
removeBottom: !filterEditorConfigs.safeArea.bottom,
child: Scaffold(
backgroundColor: filterEditorConfigs.style.background,
appBar: _buildAppBar(),
body: _buildBody(),
bottomNavigationBar: _buildBottomNavBar(),
),
),
),
),
Expand Down
16 changes: 10 additions & 6 deletions lib/features/paint_editor/paint_editor.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -880,12 +880,16 @@ class PaintEditorState extends State<PaintEditor>
controller: screenshotCtrl,
child: LayoutBuilder(
builder: (context, constraints) {
return Scaffold(
resizeToAvoidBottomInset: false,
backgroundColor: paintEditorConfigs.style.background,
appBar: _buildAppBar(constraints),
body: _buildBody(),
bottomNavigationBar: _buildBottomBar(),
return MediaQuery.removePadding(
context: context,
removeBottom: !paintEditorConfigs.safeArea.bottom,
child: Scaffold(
resizeToAvoidBottomInset: false,
backgroundColor: paintEditorConfigs.style.background,
appBar: _buildAppBar(constraints),
body: _buildBody(),
bottomNavigationBar: _buildBottomBar(),
),
);
},
),
Expand Down
18 changes: 11 additions & 7 deletions lib/features/text_editor/text_editor.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,13 +355,17 @@ class TextEditorState extends State<TextEditor>
bottom: textEditorConfigs.safeArea.bottom,
left: textEditorConfigs.safeArea.left,
right: textEditorConfigs.safeArea.right,
child: Scaffold(
resizeToAvoidBottomInset:
textEditorConfigs.resizeToAvoidBottomInset,
backgroundColor: textEditorConfigs.style.background,
appBar: _buildAppBar(constraints),
body: _buildBody(),
bottomNavigationBar: _buildBottomBar(),
child: MediaQuery.removePadding(
context: context,
removeBottom: !textEditorConfigs.safeArea.bottom,
child: Scaffold(
resizeToAvoidBottomInset:
textEditorConfigs.resizeToAvoidBottomInset,
backgroundColor: textEditorConfigs.style.background,
appBar: _buildAppBar(constraints),
body: _buildBody(),
bottomNavigationBar: _buildBottomBar(),
),
),
),
),
Expand Down
14 changes: 9 additions & 5 deletions lib/features/tune_editor/tune_editor.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,11 +389,15 @@ class TuneEditorState extends State<TuneEditor>
right: tuneEditorConfigs.safeArea.right,
child: RecordInvisibleWidget(
controller: screenshotCtrl,
child: Scaffold(
backgroundColor: tuneEditorConfigs.style.background,
appBar: _buildAppBar(),
body: _buildBody(),
bottomNavigationBar: _buildBottomNavBar(),
child: MediaQuery.removePadding(
context: context,
removeBottom: !tuneEditorConfigs.safeArea.bottom,
child: Scaffold(
backgroundColor: tuneEditorConfigs.style.background,
appBar: _buildAppBar(),
body: _buildBody(),
bottomNavigationBar: _buildBottomNavBar(),
),
),
),
),
Expand Down
Loading