wasm: Miscellaneous cleanup

[Derppening]

Cleanup the wasm backend by updating binaryen, adding missing whitespace to some lines, applying scalafmt, and performing minor code simplification.

scalafmt.conf reference:

version = "3.10.7"
runner.dialect = scala213
maxColumn = 100
project {
  includePaths = ["glob:**/hkmc2/shared/src/main/scala/hkmc2/codegen/wasm/**"]
}
fileOverride {
  "glob:**/hkmc2/shared/src/main/scala/**" {
    runner.dialect = scala3
    align.preset = none
    align.stripMargin = false
    docstrings.style = Asterisk
    newlines.source = keep
    rewrite.trailingCommas.style = always
    rewrite.scala3.convertToNewSyntax = true
    rewrite.scala3.removeOptionalBraces = true
  }
}

No functional changes.

[LPTK]

One test fails.

[Derppening]

I suspect the test failure has to do with some nondeterminism. I tried running hkmc2MostTests/test 5 times and was hit with that test failure only 3 times.

//│ FAILURE: Unexpected runtime error
//│ FAILURE LOCATION: mkQuery (JSBackendDiffMaker.scala:172)
//│ ═══[RUNTIME ERROR] Error: MLscript call unexpectedly returned `undefined`, the forbidden value.
//│     at Runtime.checkCall (file:///home/david/programming/mlscript/hkmc2/shared/src/test/mlscript-compile/Runtime.mjs:621:41)
//│     at $_stack$_safe$_body$_15 (REPL65:1:5671)
//│     at Runtime.enterHandleBlock (file:///home/david/programming/mlscript/hkmc2/shared/src/test/mlscript-compile/Runtime.mjs:953:28)
//│     at Runtime.runStackSafe (file:///home/david/programming/mlscript/hkmc2/shared/src/test/mlscript-compile/Runtime.mjs:1125:28)
//│     at REPL65:1:5722
//│     at ContextifyScript.runInThisContext (node:vm:137:12)
//│     at REPLServer.defaultEval (node:repl:600:22)
//│     at bound (node:domain:433:15)
//│     at REPLServer.runBound [as eval] (node:domain:444:12)
//│     at REPLServer.onLine (node:repl:935:10)

I also didn't change anything that is remotely related to effect handlers, so I don't think this is specific to the changes made in this branch.

Indeed, when I try to run hkmc2MostTests/test on 28cc546 (the latest commit in hkmc2) that particular test also fails 3/5 times.

[LPTK]

Whoops, some conflicts now.

[Derppening]

At least the nondeterminism seems to be gone now, running the tests back-to-back a few times doesn't trigger the test failure anymore 👍

[LPTK]

Why not commit the scalafmt.conf? You already made it apply only to a subdirectory for now.

maxColumn = 100

Normally I am for ~120. 100 Feels a bit too tight.

align.stripMargin = false

Oh, so they added the option!

[Derppening]

Why not commit the scalafmt.conf? You already made it apply only to a subdirectory for now.

Added in 1819aa9.

maxColumn = 100

Normally I am for ~120. 100 Feels a bit too tight.

Included in the scalafmt.conf and reflowed all lines in db11595.

align.stripMargin = false

Oh, so they added the option!

Actually that option affects .stripMargin calls on interpolated/string literals... From Scalafmt docs:

"If align.stripMargin is true, they will align with the opening triple-quote """ in interpolated and raw string literals. Otherwise, they will be indented relative to the start of the opening line."

[Derppening]

Seems like I messed up merging hkmc2 into this branch...

[LPTK]

Argh that stupid StackSafety.mls test is still flaky. I think I'll just disable it for now.

[LPTK]

Ok, otherwise LGTM now!

[Derppening]

I think I have addressed all of the whitespace changes.