Skip to content

added optional readstring argument to readcif (default=False)#542

Merged
jwtoney merged 2 commits into
mainfrom
read_cif_string
Apr 16, 2026
Merged

added optional readstring argument to readcif (default=False)#542
jwtoney merged 2 commits into
mainfrom
read_cif_string

Conversation

@jwtoney
Copy link
Copy Markdown
Contributor

@jwtoney jwtoney commented Apr 16, 2026

Added optional readstring argument to readcif (default=False)

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2026

Codecov Report

❌ Patch coverage is 95.83333% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.26%. Comparing base (44c0b8e) to head (b25b191).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
molSimplify/Informatics/MOF/PBC_functions.py 95.83% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #542   +/-   ##
=======================================
  Coverage   40.26%   40.26%           
=======================================
  Files          93       93           
  Lines       30325    30327    +2     
=======================================
+ Hits        12211    12212    +1     
- Misses      18114    18115    +1     
Flag Coverage Δ
unittests 40.26% <95.83%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jwtoney jwtoney merged commit 9e3c034 into main Apr 16, 2026
9 of 10 checks passed
@jwtoney jwtoney deleted the read_cif_string branch April 16, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant