refactor(chat): legacy create_messaging_message を撤去#12
Merged
Conversation
Misskey v2025 で `messaging/messages/create` が完全削除されたため
呼び出すと 404 になり、本関数自体が dead code。`chat/messages/create-to-{user,room}`
(notecli#11 で text/fileId optional 化済み) で完全代替される。
notedeck#480 で frontend を新 API 経由に切り替え済み。それと同時に
notedeck 側の `api_create_messaging_message` (Tauri command) も撤去予定。
OAuth scope の `read:messaging` / `write:messaging` (commands/auth.rs) は
別件として残す (Misskey v2025 で no-op か invalid かサーバ実装依存のため要調査)。
5 tasks
hitalin
added a commit
to hitalin/notedeck
that referenced
this pull request
May 9, 2026
[notecli#12](hitalin/notecli#12) で `create_messaging_message` 関数も削除された。本 PR の前のコミットで notedeck 側 `api_create_messaging_message` Tauri command も撤去済みなので、 notecli 上に残っていた dead 関数を削除する変更が無害に取り込める。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Misskey v2025 で
messaging/messages/create含むmessaging/*系エンドポイントが完全削除されたため、create_messaging_message関数は呼ぶと必ず 404 になる dead code。chat/messages/create-to-{user,room}(notecli#11 で text/fileId optional 化済み) で完全代替される。notedeck 側の
api_create_messaging_messageTauri command も次の notedeck PR で撤去予定。残タスク (本 PR の対象外)
commands/auth.rs:64-65の OAuth scoperead:messaging/write:messagingは別件として残す。Misskey v2025 でこれらの scope が no-op か invalid かは未調査。要する状況なら別 PR でread:chat/write:chat系に置換 (注: 公式 endpoints/chat 系のスコープが何かを確認する必要あり)。Test plan
cargo build --features specta通過cargo test --features specta通過