Open
Conversation
To adopt this PR to popup again, you need: - to change -> "const targetDoc = popupWindow?.document || document;" (at two places whare "const targetDoc = document"; is writted) - to add-> "popupWindow" at the ends of two React.useEffect()s which defines "const targetDoc" (same functions above)
Automated tests Summary🚨 Test workflow has failedClick here to check the action test reports (to view the report locally, see the docs) |
More simple implementation, although the values are slightly different from the values taken from the 'translate' value of the finally rendered HTML.
This line was missing by mistake.
By showing it, - the appearance of viewer's cursor is consistent with the presenter's - the problem that the laser remains at the presentation edge when presenter moves the cursor out of the presentation container is solved
When the cursor crosses the upper or left border of the presentation, BBB place the cursor at (-1, -1). This behaviour makes the laser 'jump' to the upper-left position.
With this change, the viewer's laser will be created every time as the page changes. Is there any better implementation???
hiroshisuga
force-pushed
the
v3.0.x-release
branch
from
5f0f2af to
9dbfaaa
Compare
|
This pull request has conflicts ☹ |
🚨 Automated tests failed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Laser pointer implementation]
Motivation
To do and problems