Failed to set access_token as attribute#43
Open
Jaidan wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client_credentials grant_types fails due to the access_token being incorrectly referenced.
As an important aside, I wouldn't pull this into any version just yet. As implemented the client_credentials grant_type is a security mess and should never be implemented as it is here. As is noted here:
http://tools.ietf.org/html/draft-ietf-oauth-v2-31#section-4.4
This is highly important. As this basically allows client to self authorize. There are situations where this can be a good thing, but they are pretty rare.
Some thought I will likely be needed to decide an appropriate way to to protect this version token grant_type, in my case I will be using a custom client model and a flag, but that may not be suitable for all cases.