fix(converter): use vkGetDescriptorEXT for descriptor buffer population#13
Merged
Merged
Conversation
cb39993 to
83ecbdb
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a descriptor-buffer regression introduced after updating ash (#11) where the converter’s compute shader could read invalid/uninitialized descriptor data (observed as a constant-green output channel when streaming), by switching descriptor population to Vulkan’s runtime descriptor writer API.
Changes:
- Populate descriptor-buffer contents via
vkGetDescriptorEXT(ash::ext::descriptor_buffer::Device::get_descriptor) instead ofvkGet*OpaqueCaptureDescriptorDataEXT. - Use the correct runtime descriptor sizes (
*_descriptor_size) fromVkPhysicalDeviceDescriptorBufferPropertiesEXT. - Track the output buffer’s size and device address to build a
VkDescriptorAddressInfoEXTfor the STORAGE_BUFFER binding.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/converter/pipeline.rs |
Adds output buffer device-address usage/address tracking and switches to runtime descriptor-size queries. |
src/converter/mod.rs |
Replaces opaque capture descriptor flow with per-frame vkGetDescriptorEXT writes into the mapped descriptor buffer. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
Thanks! I didn't test this yet in Moonshine. I used the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#11 seems to have introduced a regression that causes me to get a completely green video channel when streaming via moonshine HEAD. It looks like it was caused by ColorConverter shader was reading uninitialized descriptors. As far as I can tell, I think we need to use
vkGetDescriptorEXTinstead.Tested on 9070XT with HEAD/main from moonshine, with git bisect on pixelforge and it looks like #11 definitely introduced it and this PR fixes it, but an extra set of eyes and test on non-AMD hardware would be appreciated.