Skip to content

sys_pipe2: prevent file descriptor leak on copy_to_user failure #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hexagonal-sun merged 1 commit into from
Apr 3, 2026
Merged

sys_pipe2: prevent file descriptor leak on copy_to_user failure #276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/fs/pipe.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,9 +283,14 @@ pub async fn sys_pipe2(ctx: &ProcessCtx, fds: TUA<[Fd; 2]>, flags: u32) -> Resul
(read_fd, write_fd)
};

// TODO: What if the copy fails here, we've leaked the above file
// descriptors.
copy_to_user(fds, [read_fd as _, write_fd as _]).await?;
// copy_to_user will only EFAULT
if let Err(e) = copy_to_user(fds, [read_fd as _, write_fd as _]).await {
// Clean up the file descriptors we created.
let mut fds = ctx.task().fd_table.lock_save_irq();
fds.remove(read_fd);
fds.remove(write_fd);
return Err(e);
}

Ok(0)
}
Loading